Binnie's Mods

Binnie's Mods

26M Downloads

[1.7.10] Genetics machine is not animated

KorDum opened this issue ยท 8 comments

commented

This didn't work from the very beginning of the port on Forestry 4.2.
Not show animation in progress.

commented

Please help.

public void sendPacket() {
if (!BinnieCore.proxy.isSimulating(this.getTileEntity().getWorldObj())) {
return;
}
BinnieCore.proxy.sendNetworkEntityPacket((INetworkedEntity) this.getTileEntity());
}

Earlier in the code there was such a method. But the method was not used anywhere else.
Maybe there is no some annotation?
I already broke my head...

commented

@KorDum You need to add INetwork.TilePacketSync for all logic component(3e9965b#diff-2578bb0b23cc8ae4f6999777fbd96e7dR16) or rewrite this: https://github.com/ForestryMC/Binnie/blob/master-MC1.7.10/src/main/java/binnie/core/machines/ManagerMachine.java#L44 because it doesn't check super class

commented

Thanks!

You need to add INetwork.TilePacketSync for all logic component

Oh! That's simple!

Look at 1.11.

Code is not finished? I don't understand this blank check.

commented

Code is not finished? I don't understand this blank check.

@KorDum this line is the most important. if is not needed.

Could you test code below without PR #192 :

for (Class<?> currentClass = component; currentClass != null; currentClass = currentClass.getSuperclass()) {
    Collections.addAll(interfaces, currentClass.getInterfaces());
}
commented

@marcin212

for (Class<?> currentClass = component; currentClass != null; currentClass = currentClass.getSuperclass()) {
    Collections.addAll(interfaces, currentClass.getInterfaces());
}

yes, it's work.
Is this fix preferable to add INetwork.TilePacketSync for all logic component?

commented

I created 2 separated PR.
Can you approve right one?
#196
#192