Binnie's Mods

Binnie's Mods

Mods
26M Downloads

[1.12] Botany lacks oredicts

asiekierka opened this issue ยท 7 comments

commented

Pigmented Glass should be blockGlass, IMO. Not sure if Clay shouldn't also be oredicted...

commented

@mezz I looked at the code, it seems to be fixed?

commented

I don't see "blockGlass" anywhere in the project, I don't think this has been fixed.

commented

Single mention

Binnie/botany/src/main/resources/assets/botany/lang/en_US.lang

Line 39 in 66eabfc

botany.pigmented.glass.name=%s Pigmented Glass

so i think this is it

Binnie/botany/src/main/java/binnie/botany/blocks/BlockStainedGlass.java

Lines 141 to 145 in 66eabfc

@Override
public String getDisplayName(ItemStack itemStack) {
EnumFlowerColor color = EnumFlowerColor.get(TileEntityMetadata.getItemDamage(itemStack));
return I18N.localise("botany.pigmented.glass.name", color.getDisplayName());
}

They are registered now without a Oredictionary

Binnie/botany/src/main/java/binnie/botany/modules/ModuleCeramic.java

Lines 54 to 75 in 66eabfc

@Override
public void registerItemsAndBlocks() {
ceramic = new BlockCeramic();
stained = new BlockStainedGlass();
ceramicTile = new BlockCeramicPatterned();
ceramicBrick = new BlockCeramicBrick();
misc = new ItemMisc(CreativeTabBotany.INSTANCE, CeramicItems.values(), "misc_ceramic");
pigment = new ItemPigment();
clay = new ItemClay();
Botany.proxy.registerBlock(ceramic, new ItemCeramic(ceramic));
Botany.proxy.registerBlock(stained, new ItemStainedGlass(stained));
Botany.proxy.registerBlock(ceramicTile, new ItemDesign(ceramicTile));
Botany.proxy.registerBlock(ceramicBrick, new ItemCeramicBrick(ceramicBrick));
Botany.proxy.registerItem(pigment);
Botany.proxy.registerItem(clay);
Botany.proxy.registerItem(misc);
OreDictionary.registerOre("pigment", pigment);
}

Therefore, it seemed to me that the problem was no longer relevant

commented

Ah, I misunderstood the problem.

commented

@mezz Where can I look at the keys for the Oredictionary ("blockGlass")? In the source code of forge?

commented

You can find it in Forge here:
https://github.com/MinecraftForge/MinecraftForge/blob/a40df67004dc02c502f7b07d8fe7e6349273514c/src/main/java/net/minecraftforge/oredict/OreDictionary.java#L203-L205

Ore dictionary is just a loose agreement between mods, lots of them are not in Forge at all. For this though there is a pretty clear case for it in Forge.

commented

@mezz Probably you can close it too?