Binnie's Mods

when i seach steel or charcoal,the game will crash,when i disable Extra Trees will nothing.
Forgive me my bad English

crash report
charcoal
steelsimple pack no steel..

Relevant part of chromaticraft https://github.com/ReikaKalseki/ChromatiCraft/blob/56819445d4cad5880f7b37f08c39cdd63d53b452/TileEntity/Processing/TileEntityCrystalFurnace.java#L195-L202. Relevant part of Binnie

Binnie/src/main/java/binnie/extratrees/block/BlockETLog.java

Lines 129 to 131 in 765dade

    
           public String getBlockName(ItemStack itemStack) { 
        
           	int meta = TileEntityMetadata.getItemDamage(itemStack); 
        
           	return I18N.localise("extratrees.block.log.name", ILogType.ExtraTreeLog.values()[meta].getName());

. Something calls getBlockName with ore dictionary wildcard it looks like. I don't know if this should be fixed by Binnie or Chromaticraft.

To stop this crash, we should use meta 0 when it's out of range.
I had an argument with Reika about this before with Forestry, they're badly misusing the ore dictionary and will not fix it.
ReikaKalseki/Reika_Mods_Issues#530

For some reason the PR didn't auto close this but I believe that this is sorted now.

I think github will only auto-close from commits on the main branch. This was on 1.7.10 so it didn't do it.

	public String getBlockName(ItemStack itemStack) {
	int meta = TileEntityMetadata.getItemDamage(itemStack);
	return I18N.localise("extratrees.block.log.name", ILogType.ExtraTreeLog.values()[meta].getName());

Share to