Biome Particle Weather

Biome Particle Weather

2M Downloads

Nether Weather causing lag in overworld

ShotCosine opened this issue · 11 comments

commented

Minecraft 1.18.2
Biome Particle Weather 2.3.4

For other users experiencing this issue: turn off nether weather when not in the nether.

It seems like with the nether weather settings enabled, the game gets more and more laggy overtime in the overworld. When first loading into a world, the game is at the slowest performance, and if the mod is refreshed by changing a config the lag goes away temporarily. Pausing the game causes the fps to go up to normal levels, usually 30fps more. Fps drops do not appear in the nether, and go away in the overworld when the nether weather settings are turned off.

With nether weather settings enabled:
2022-03-27_23 18 03

With nether weather settings disabled:
2022-03-27_23 18 57

commented
commented

ok so im going to need you help me test this patch so download the file on github (bpetest.jar) and lemme know if i fixed it

commented

Crashed!

A mod crashed on startup!
net.fabricmc.loader.impl.FormattedException: java.lang.RuntimeException: Could not execute entrypoint stage 'preLaunch' due to errors, provided by 'advanced_runtime_resource_pack'!
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:159)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:71)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: java.lang.RuntimeException: Could not execute entrypoint stage 'preLaunch' due to errors, provided by 'advanced_runtime_resource_pack'!
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51)
at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35)
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:157)
... 2 more
Caused by: net.fabricmc.loader.api.EntrypointException: Exception while loading entries for entrypoint 'preLaunch' provided by 'advanced_runtime_resource_pack'
at net.fabricmc.loader.impl.entrypoint.EntrypointContainerImpl.getEntrypoint(EntrypointContainerImpl.java:56)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47)
... 4 more
Caused by: java.lang.RuntimeException: Mixin transformation of net.devtech.arrp.ARRP failed
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:252)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:150)
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:155)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:467)
at net.fabricmc.loader.impl.util.DefaultLanguageAdapter.create(DefaultLanguageAdapter.java:50)
at net.fabricmc.loader.impl.entrypoint.EntrypointStorage$NewEntry.getOrCreate(EntrypointStorage.java:117)
at net.fabricmc.loader.impl.entrypoint.EntrypointContainerImpl.getEntrypoint(EntrypointContainerImpl.java:53)
... 5 more
Caused by: org.spongepowered.asm.mixin.throwables.MixinApplyError: Mixin [ImpactfulWeather.mixins.json:WorldRendererMixin] from phase [DEFAULT] in config [ImpactfulWeather.mixins.json] from mod [impactfulweather] FAILED during PREPARE
at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinError(MixinProcessor.java:638)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinPrepareError(MixinProcessor.java:585)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.prepareConfigs(MixinProcessor.java:543)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.select(MixinProcessor.java:462)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.checkSelect(MixinProcessor.java:438)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:290)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:247)
... 13 more
Caused by: org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException: The specified mixin 'shadowmaster435.impactfulweather.mixin.WorldRendererMixin' was not found
at org.spongepowered.asm.mixin.transformer.MixinInfo.(MixinInfo.java:865)
at org.spongepowered.asm.mixin.transformer.MixinConfig.prepareMixins(MixinConfig.java:852)
at org.spongepowered.asm.mixin.transformer.MixinConfig.prepare(MixinConfig.java:781)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.prepareConfigs(MixinProcessor.java:540)
... 19 more
Caused by: java.lang.ClassNotFoundException: The specified mixin 'shadowmaster435.impactfulweather.mixin.WorldRendererMixin' was not found
at org.spongepowered.asm.mixin.transformer.MixinInfo.loadMixinClass(MixinInfo.java:1314)
at org.spongepowered.asm.mixin.transformer.MixinInfo.(MixinInfo.java:858)
... 22 more

commented

no, same mod list. tried deleting config but it still crashed

commented

hmm

commented
commented

strange as i havent changed anything that couldve done this to my knowledge

commented

alright try it again

commented

this patch fixed the lag in the overworld! there are some fps drops in the nether when the permanent nether weather is enabled, which i forgot to mention before, but disabling this returns the fps. What does the permanent nether weather setting do? it seems to just disable the updraft particles for me.

commented

it should re-enable the timer i made for nether weather (yes nether weather doesn't operate the same way as normal weather)

commented

alright imma close this now