Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.21.4

Mod Version (Required)

v5.3.3

Notes (Required)

Hello!
First of all, absolutely love the mod - it makes the world so much livelier and it is a Staple in my mods now. However, I seem to have encountered a bug/issue with the way the mod interacts with the rendering pipeline. Disabling the Vanilla Rain rendering, which I assume disables the call to renderWeather, cuts off the rendering pipeline at the weather rendering stage. Aka, any mods, particles, etc. that have their rendering passes after the weather pass get completely cut off. I have seen this issue arise with a few mods that pass their renders after the weather, and disabling BPW's Vanilla Rain Rendering completely disables any visual part of the mods. Perhaps hooking into renderWeather and then immediately returning would be a smoother alternative to not avoid breaking the Vanilla Rendering Pipeline? If BPW does not disable the call entirely and does something else that prevents subsequent passes from rendering, I apologise for my mistake - but hopefully things could be figured out?
Have a great day.

latest.log (Optional)

No response

Hi! The mod does in fact already does what is described here. The mod also does not disable any subsequent render passes as far as im aware. Are you 100% sure its my mod?

Hello, hope all is well!
After filtering through the mods BPW was the only one that caused this issue as far as I’m aware, but perhaps there is an incompatibility with another mod? I have attached a small video of this issue happening, with the the mod Loot Beams, which calls its render after the weather rendering. Apologies if I misunderstood BPW’s behaviour!

Ah. Yes its my mod then HOWEVER that is an incredibly strange place for the dev of that mod to put rendering code unrelated to weather rendering i cant think of an easy fix on my end so id recommend making an issue on that mods github

I discussed it with the mod dev and he said that he just does his rendering after (and outside of) the weather rendering pass in the sequence of render calls, as its own render pass - so that the loot beams show up in front of any rain/snow, and the rendering pipeline is not cut or altered, simply extended. Any idea what the cause might be?