Biomes O' Plenty

Biomes O' Plenty

151M Downloads

BiomeDictionary entries not respected for entity spawning

capnkirok opened this issue ยท 2 comments

commented

Issue Description:

Animania animals do not spawn in BOP biomes, even though using BiomeDictionary.
Also, vanilla rabbits appear to be spawning even though they should be replaced by Animania. Wondering if you are forcing your own spawns?

Steps to reproduce:

  1. Install Animania next to BOP, create new world
  2. Look for biome based Animania breeds in BOP biomes (e.g. Angus or Hereford Cows, or Old Spot pigs) - and not the default vanilla replacements (like Friesian Cow or Yorkshire Pig).

Additional Information:


Affected Versions (Exact numbers, do NOT use "latest"):

  • Biomes O' Plenty: 1.12 7.0.0.2291
  • Animania 1.12.2 v1.3.5
  • Minecraft: 1.12.2
  • Forge: 1.12.2, *2489
commented

BoP biomes are indeed adding their biomes to the BiomeDictionary:

private static void registerBiomeDictionaryTags()

I'm using BiomeDictionary to spawn penguins in Waddles as well, and they spawn just fine in BoP biomes. Could you link the class where you handle it in Animania? :)

commented

Hey @GirafiStudios ! Guess what.. it's not you, it's me!

I actually spawn in two different ways... one way, the normal way when you register entities... and there my code uses BiomeDictionary.

But, I also replace vanilla animals as well. And there, I am not checking BiomeDictionary. This explains the discrepancy. So you can safely ignore this one.