Generator configuration files not actually working :-(
SnowShock35 opened this issue · 12 comments
Issue Description:
Generator properties for biomes don't appear to be working at all. For example, in the supplied example configuration file for the extreme hills + biome I've disabled shrubs (even trying to use multiple methods e.g. enable
, amountPerChunk
and generationAttempts
flags), but despite my attempt to do so they're still showing up in this biome (as seen from the screenshot supplied).
There's no log indication as to why this doesn't work so therefore I've excluded logs for that reason. Should you require them, please inform me and I will supply a link to a paste-bin.
Steps to reproduce:
- Use the given versions, and configuration files
- Load the game
- Create a new world with
Game Mode:
set to Creative and theWorld Type:
set to Biomes O' Plenty and then clickCreate New World
- Use the command
/biomesop tpbiome 34
to teleport to a Extreme Hills + biome where you'll find the shrubs appearing.
Additional Information:
- Config (config/biomesoplenty/biomes/extreme_hills_with_trees.json): https://pastebin.com/iwTCs0J5
- Screenshots:
Affected Version(s) (Exact numbers, do NOT use "latest"):
- Java: 1.8.0_25 (64-bit)
- Minecraft: 1.12.2
- Minecraft Forge: 14.23.0.2515
- Biomes O' Plenty: 7.0.1.2299
The config file name must match the biome name, in lowercase with underscores. Hence, extreme_hills_with_trees will not work. This is specified on the wiki page https://github.com/Glitchfiend/BiomesOPlenty/wiki/Configuring-Biomes
Also keep in mind, logs indicate when a config file has been loaded. If there's nothing in the logs, it means it wasn't loaded
according to the minecraft wiki that is the biome name lowercased and w/ underscores. See: https://minecraft.gamepedia.com/Biome#Biome_IDs
Huh, yeah, looks like you're right. I was under the impression we didn't change over to using the proper ids yet, but I guess I must've done it whilst updating.
Yeah, I've been at this now a good 8 hours trying to be able to configure the biomes' features. However it's proving rather tricky.
Could you paste your logs? You should be getting the message "extreme_hills_with_trees.json: Detected config file". I just tried this and it doesn't work, as I suspected. However, extreme_hills+.json does work, and the shrubs are removed as expected.
I guess the confusion here stems from the default files being named using the ids, however the files being checked for are still the biome names, as described on the wiki.
For all of our biomes they are the same, which is why it wasn't an issue when the feature was initially added. But since then we allowed for Vanilla biomes to be configured, and unfortunately they have some mismatched names/ids.
Yeah it seems you're write with that. I'm not seeing that one in the log and if you're saying that extreme_hills_+.json works then that would suggest that the system was in fact not changed over.
So I should just change my config names over right?
Would it be possible to implement the newer names since it matches with the wiki?