No Forge Events Fire
jprocket45 opened this issue ยท 7 comments
Issue Description:
(this.settings.useDungeons && TerrainGen.populate(this, world, rand, chunkX, chunkZ, hasVillageGenerated, DUNGEON))
{
for (int i = 0; i < this.settings.dungeonChance; ++i)
{
target = decorateStart.add(this.rand.nextInt(16), this.rand.nextInt(256), this.rand.nextInt(16));
(new WorldGenDungeons()).generate(this.world, this.rand, target);
}
}
this is hard coded and doesn't seem to fire forge events in their ChunkGeneratorOverworldBOP class like they should.
ChunkPopulation event and The event that allows for vanilla dungeon replacement
are both missing
Steps to reproduce:
- install Biomes O' Plenty 1.12.2-7.0.1.2402
- install Dungeon Tweaks 1.2.5.2 , EvilNotchLib 1.2.3 Snapshot 76
- change configs in Dungeon tweaks to what you want in spawners load world will not change anything due to events not firing.
Additional Information:
- fml-client-latest.log or fml-server-latest.log:
- Screenshots:
Affected Versions (Exact numbers, do NOT use "latest"):
- Biomes O' Plenty: 1.12.2-7.0.1.2402
- Minecraft: 1.12.2
- Forge: 2768
your world didn't fire forge events so unless you fixed this already this issue still persists
The chunk population events are all posted correctly on BoP's side identically to how they are posted in vanilla. The issue can't be here.
https://github.com/Glitchfiend/BiomesOPlenty/blob/BOP-1.12.x-7.0.x/src/main/java/biomesoplenty/common/world/ChunkGeneratorOverworldBOP.java#L498
https://github.com/Glitchfiend/BiomesOPlenty/blob/BOP-1.12.x-7.0.x/src/main/java/biomesoplenty/common/world/ChunkGeneratorOverworldBOP.java#L555
https://github.com/Glitchfiend/BiomesOPlenty/blob/BOP-1.12.x-7.0.x/src/main/java/biomesoplenty/common/world/ChunkGeneratorOverworldBOP.java#L596
then you fixed it since the initial report congrats last time you override methods and removed forge's events in certain instances during chunk population events thanks for fixing this
That specific part of the file hasn't changed since June 2015, so no, it's always been that way. (Also fyi those links may no longer work as we renamed that branch within the past few hours).
I can confirm bug does exist and my forge events that hook into dungeon and chunk population do simply not fire