Biomes O' Plenty

Biomes O' Plenty

Mods
151M Downloads

Missing "dye" ore dictionary registration

LemADEC opened this issue ยท 2 comments

commented

Issue Description:

On a large modpack, about 33% recipes are missing with Biome's O Plenty dyes. This includes notably recipes for WarpDrive tools, ThermalInnovation Injector, ThermalInnovation Quiver, ThermalExpansion Satchel, Capacitor & Reservoir, etc.

This is due to dies being only registered for their color in the ore dictionary. They should also be registered to the generic 'dye' ore dictionary.

Steps to reproduce:

  1. add a mod that shows ores registration, for example CraftTweaker (use the /ct hand command) or EnderIO (check tooltip while item is in inventory).
  2. check vanilla dies, observe how they have 2 ores registered: "dyeXXX" and "dye", where XXX is the related color for that dye.
  3. check Biomes'o plenty dies, observe how they only 1 ore registered: "dyeXXX", where XXX is the related color for that dye.

Additional Information:

  • fml-client-latest.log or fml-server-latest.log: n/a
  • Screenshots: n/a

Affected Versions (Exact numbers, do NOT use "latest"):

  • Biomes O' Plenty: 1.12.2-7.0.1.2422
  • Minecraft: 1.12.2
  • Forge: 14.23.5.2796
commented

I've never used any of those mods, but assuming they use the ore dictionary for their recipes, having a generic dye tag isn't going to change anything. They likely have hardcoded recipes that don't use the JSON system.

Anyway, dyes are being removed in the next major update to Biomes O' Plenty, so I'm not gonna bother looking into this any further.

commented

Ore dictionary is usable in the JSON system with a fore extension.
The generic dye allows to reduce clutter in the recipes listed (listing only one generic instead of 16 as 1 per dye).