Biomes O' Plenty

Biomes O' Plenty

151M Downloads

Client particles are created with server world instance

jellysquid3 opened this issue ยท 2 comments

commented

Relevant issue on Phosphor's issue tracker where this was discovered.

To summarize the discovery in that thread, BOP's sided proxy is being used to spawn particles on the client from the server, which causes particles to be instantiated with the server's world object. This is incredibly bad for a number of reasons, but primarily because it allows the client thread to mutate data belonging to the server thread, which in this case causes a myriad of horrible things to happen inside Phosphor.

The sided proxy method where these particles are being spawned can be found here.

This is likely the cause of #1293, #1350, #1326, and #1305.

commented

I've opened PR #1372 to fix this issue.

commented

Yep players on my pack seem to have this issue some times as well is this fixable? https://pastebin.com/08pZr78G