Crash on modpack, odd crash
Dark-Strife opened this issue ยท 4 comments
Bug Report
How can the crash be reproduced?
Happened only when loading my modpack, never crashed like this before. Only crashed because of this mod.
Crash Report and Logs
crash-2020-12-09_07.43.18-fml.txt
Mod Version
BiomesOPlenty-1.16.4-13.0.0.422-universal
also sorry if its not standalone, new on the site, followed the link from the crash report.
This seems to be a Forge thing, as I get it with pretty much any combination of mods.
This is caused by BoP not having any thread-safety at all when registering compostables, flammables, etc.
They're loaded during the common setup event, which is run in parallel with other mods in Forge (and has been for quite a while now, since something like Minecraft 1.14 or so). Registering these things should be done by wrapping it similarly to this:
private void commonSetup(final FMLCommonSetupEvent event)
{
event.enqueueWork(() -> {
ModVanillaCompat.setup();
}
}
The above would cause the vanilla compat to be run on the main thread instead of trying to do it at the same time as every other mod that happens to also lack thread safety.