Biomes O' Plenty

Biomes O' Plenty

170M Downloads

Willow Leaves "mossy" state doesn't affect block model & "magic_leaves_alt.png" is completely unused

zndrmn opened this issue ยท 3 comments

commented

What's the issue you encountered?

willow_leaves has completely unused textures (willow_leaves_mossy.png & willow_leaves_mossy_overlay.png) which causes the "mossy" state to basically be completely useless and doesn't change the model/texture depending on if it's mossy or not.

Image

also magic_leaves has an unused texture: magic_leaves_alt.png. I'm not sure if this was left in on accident or just never got given a model and added to the blockstates.

How can the issue be reproduced?

place spanish_moss under willow_leaves and notice that nothing changes despite "mossy" being true.

Logs

No response

Mod Version

1.21.4-21.4.0.23

Additional information

No response

commented

It seems like these both got messed up when our blockstates were changed to be datagenned. Will be fixed when we update to 1.21.5

commented

During the update to 1.21.5, I decided it wasn't really worth keeping the mossy state for Willow Leaves, cause it would've been a bit messy to reimplement, and I feel like it was kind of janky to begin with. I also made Magic Leaves use the alt texture by default now, and I think it looks better like this anyway.

commented

yeah when I was trying to add the mossy state back myself with a resource pack things started to just randomly start breaking and not display the correct model after I had a certain amount of different possible model variants.