Biomes O' Plenty

Biomes O' Plenty

151M Downloads

Can't comiple

ajthemacboy opened this issue ยท 17 comments

commented

Hi! I'm having trouble compiling BOP on Ubuntu Linux with the Java 8 JDK.

Here's the log: http://paste.ubuntu.com/11062365/

I don't know how to interpret the stacktrace; it says this at one point:

/home/aj/Desktop/BOP/BiomesOPlenty/build/sources/java/biomesoplenty/common/items/ItemJarFilled.java:129: error: ')' expected entityPlayer.setCurrentItemOrArmor(0, new ItemStack(BOPCItems.jarEmpty, 1, 0);

Is this an issue with BOP or with my setup? Thanks for your help!

commented

Looks like @wwrpg broke something by this commit.

commented

I have an idea how to fix it. Hold on.

commented

replace with
entityPlayer.setCurrentItemOrArmor(0, new ItemStack(BOPCItems.jarEmpty, 1, 0));

commented

I fixed it and another issue too. Just need to test :)

commented
commented

I said I'm fixed it :)

commented

ok =\

commented

I cloned a fresh copy of the repo, but this is still happening when I run ./gradlew build:

warning: [options] bootstrap class path not set in conjunction with -source 1.6 /home/aj/Desktop/BiomesOPlenty/build/sources/java/biomesoplenty/common/items/ItemJarFilled.java:129: error: ')' expected entityPlayer.setCurrentItemOrArmor(0, new ItemStack(BOPCItems.jarEmpty, 1, 0);

commented

My PR not yet merged (and you can't fork it since I removed branch with the fix but it still can be merged). You have to wait.

commented

Alright thanks. I saw that the repo had been updated today and just assumed it had been fixed.

commented

Alright, I applied the fix myself, but now when I try to compile I get this error (the old one is gone):

/home/aj/Desktop/BiomesOPlenty/build/sources/java/biomesoplenty/common/blocks/BlockBOPColorizedSapling.java:75: error: no suitable method found for canBlockStay(World,int,int,int,int) if (!this.canBlockStay(world, x, y, z, meta))

With a little ^ sign pointing to the period in !this.canBlockStay

commented

Change "canBlockStay" to "isValidPosition"

commented
commented

Real sorry about that! I tested and compiled it fine on my computer... but then I failed to copy all the changes to github and typed in some of my changes by hand (forgetting the extra ")").

commented

No worries. You made great bugfixes. Hope you'll fix some more bugs later.

commented

I really love the mod, and how much it adds! And I since I know how to mod, I thought I might as well help contribute a little. From now on out I'll double check my changes in github compile before pulling a request.

commented

By the way, do I need to run gradlew setupDecompWorkspace before I compile?