Biomes O' Plenty

Biomes O' Plenty

151M Downloads

[1.7.10] HTTP Request Made In Main Client Thread During PreInit

rallias opened this issue ยท 3 comments

commented

In multiple locations, there are HTTP requests causing the client to load observably slower. Using Sampler's startup.nbs file, this issue directly causes 2964ms of unnecessary delay in biomesoplenty.common.utils.remote.TrailsVersionChecker.getInstance(), and 1109ms in biomesoplenty.common.utils.remote.FlowerTrailManager.getInstance() within the FMLPreInitializationEvent portion of loading.

commented

Despite the fact that the files are in the correct location, it is still trying to download them every time

commented

@Adubbz this should be fixed by this commit e8cb5af, right?

commented

Should be, although it's not something i've tested. As a general note, startup time is generally not something considered unless the amount is extremely noticable (e.g. upwards of 30 seconds which even then, depends on what the mod is doing). To be honest, a startup time of ~4 seconds is reasonable for most large mods. However, downloading was indeed broken with other impacts as well. I'll close this unless this is still seemingly a vexing issue.