Biomes O' Plenty

Biomes O' Plenty

Mods
151M Downloads

BlockBOPLeaves drops ItemStack with null ITem

Aaron1011 opened this issue ยท 1 comments

commented

Issue Description:

In BOP for Minecraft 1.8.9, BlockBOPLeaves#getItemDropped can return a null Item. Since BlockLeaves does not perform a null check when calling this method, an ItemStack with a null Item gets created.

When an EntityItem is spawned in with the bad ItemStack, other mods break when expecting a non-null Item.

Steps to reproduce:

  1. Place several 'Giant Red Flower Petal' block
  2. Break the block repeatedly with an axe, until an item drops.
  3. Observe that the spawned EntityItem has an ItemStack with a null Item.

Affected Versions (Exact numbers, do not use "latest"):

  • Biomes O' Plenty: BiomesOPlenty-1.8.9-3.0.0.1935
  • Minecraft: 1.8.9
  • Forge: 1763
commented

I'll copy the changes over to 1.8.9 in a bit