Biomes O' Plenty

Biomes O' Plenty

151M Downloads

support for Calculator Ametyst and Tanzanite

0Navis0 opened this issue ยท 9 comments

commented

There is no any support for the Calculator gems, so they can't be used in the Calculator machines and recipes, and Calculator gems can't be used in the Biomes O Plenty recipes. I had already reported this issue to the Calculator owner, but he told me that it was Biomes O Plenty wich didn't register well its gems in the ore dictionnary while Calculator did. SonarSonic/Calculator#149

commented

Our gems are intentionally not registered with the ore dictionary, as they are used with the late-game items like the Biome Finder and Enderporter. Gems of the same type from other mods might be obtained in other ways, and it would ruin the balance of said items.

If it really matters, there are mods that can add custom crafting recipes.

commented

That it's pretty stupid because it ruins the compatibility and balance between mods.

commented

I really don't care. I'm not having our mod become unbalanced because of some things another mod adds that our mod also has.

commented

One thing you could do is to register BoPs gems in the ore dictionary, but still make the recipes in BoP that requires those only take BoP gems - so it is possible to use BoPs gems in other mods recipes.

commented

Actually, I just checked. That IS how it is currently, and our gems are in the ore dictionary. Amethyst is exempt though for some reason.

for (BOPGems gem : BOPGems.values())
        {
            if (gem == BOPGems.AMETHYST) {continue;}
            String gemName = CaseFormat.UPPER_UNDERSCORE.to(CaseFormat.UPPER_CAMEL, gem.name());
            OreDictionary.registerOre("gem"+gemName, new ItemStack(BOPItems.gem, 1, gem.ordinal()));
            OreDictionary.registerOre("ore"+gemName, new ItemStack(BOPBlocks.gem_ore , 1, gem.ordinal()));
        }
commented

It seems curruntly impossible to use the amethyst and tanzanite in the Calculator recipes. And both of you say that it's the fault of the other. So it would maybe be the time to agree with each other...

commented

Amethyst would not work, tanazanite should. What ore dict name are Calculator using for tanazanite?

commented

Why Ametyst isn't registered in ore dict ? And I don't know, you have to ask that to the Calculator owner.

commented

That is a good question, only @Adubbz would be able to answer that question.