Issue Description:

BOP rock formation doesn't connect with stone types from Underground Biomes.

Steps to reproduce:

1. Install BOP and Underground Biomes.
2. Create a new world.
3. Find a cave with rock formation.

Additional Information:

Affected Versions

• Biomes O' Plenty: 5.0.0.2109
• Underground Biomes: 0.9 Beta 11
• Minecraft: 1.10.2
• Forge: 12.18.3.2185

Will a potential fix affect an existing world or will the once generated blocks stay like this?

It's more of a matter of having BoP Formations realize "hey that's stone" and connecting it properly. It works fine with vanilla stone and variants like granite. Also it should just fix it, since it's a connected texture; if you replace the UBC stone with vanilla, you'll see it connect like it's supposed to.

https://github.com/Glitchfiend/BiomesOPlenty/blob/BOP-1.11.x-6.0.x/src/main/java/biomesoplenty/common/block/BlockBOPStoneFormations.java#L99-L100

        boolean groundAbove = (worldIn.getBlockState(pos.up()).getBlock() == Blocks.STONE);
        boolean groundBelow = (worldIn.getBlockState(pos.down()).getBlock() == Blocks.STONE);

@Adubbz
These booleans can possibly be set to a check against Material.ROCK instead of Blocks.STONE

I removed rock formations recently, so this issue is no longer needed.

A bit late, but the problem with using the rock material is that a lot of different blocks use it that aren't necessarily naturally generated rocks.

If they have an API, we could use that, but it's not a priority at all.

Thanks for not forgetting this one.

the problem with using the rock material is that a lot of different blocks use it that aren't necessarily naturally generated rocks.

But in the "naturally" generated world this won't be a problem, right? What I mean: When using Material.ROCK instead of Blocks.STONE, the rock formation would connect with a lot more blocks that aren't there when the world is generated, and if they are placed, the formation would connect with the block, but this would still look better than floating formations connected with nothing.

But in the "naturally" generated world this won't be a problem, right?

Even vanilla minecraft generates structures (underground, no less!) using stone_brick and cobblestone. Many many mods are available that do further structure generation to one extent or another.

blockAbove = worldIn.getBlockState(pos.up()).getBlock();
groundAbove = (blockAbove == Blocks.STONE || blockAbove == Material.ROCK);
blockBelow = worldIn.getBlockState(pos.down()).getBlock();
groundBelow = (blockBelow == Blocks.STONE || blockBelow == Material.ROCK);

this would still look better than floating formations connected with nothing.

Or not?