Crash with Ye Gamol Chattels
Qohelethh opened this issue · 4 comments
Ivorforce said to send this to you to see if you can address it. I get the following crash on a server when both Ye Gamol Chattels and BiomeTweaker are installed: https://gist.github.com/Qohelethh/0778f6de115231802753
The crash actually results from him loading the model classes on the server. He never actually does anything with them which is why his mod doesn't crash outright. I first encountered this issue with QuiverBows.
BiomeTweaker attempts to resolve super classes so that it can patch any classes that improperly override color methods in BiomeGenBase. When it does this, it fails to resolve the model classes since they simply aren't there. Luckily, there is a way to fix this on my end until @Ivorforce manages to get the models classes to not load on the server. Either way, you're going to need an unreleased version of BiomeTweaker, build 101 or later. I would recommend downloading the latest build (107).
With the latest build, everything should work fine, but you will see some exceptions from BiomeTweaker. If those are really annoying you, you can do two things.
- Enable light asm mode. This will cause BiomeTweaker to not do any superclass resolution. This will break color overrides in some biomes, but the errors will disappear.
- Add the classes to the ASM blacklist. BiomeTweaker will ignore only those classes when resolving superclasses. This is the best solution, but you need to be able to find what classes are causing the crash.
Again, you don't have to do either of these. The latest build will work regardless. These will just remove the errors. I will close this issue when I release version 1.0.
Thanks for your detailed reply. I'll download the latest version and give
it a try.
On 29 May 2015 20:51, "Chris" [email protected] wrote:
The crash actually results from him loading the model classes on the
server
https://github.com/Ivorforce/YeGamolChattels/blob/master/src/main/java/ivorius/yegamolchattels/blocks/EnumPedestalEntry.java#L13.
He never actually does anything with them which is why his mod doesn't
crash outright. I first encountered this issue with QuiverBows.BiomeTweaker attempts to resolve super classes so that it can patch any
classes that improperly overrides color methods in BiomeGenBase. When it
does this, it fails to resolve the model classes since they simply aren't
there. Luckily, there is a way to fix this on my end until @Ivorforce
https://github.com/IvorForce manages to get the models classes to not
load on the server. Either way, you're going to need an unreleased version
of BiomeTweaker, build 101
http://jenkins.superckl.me/job/BiomeTweaker/101/ or later. I would
recommend downloading the latest build (107)
http://jenkins.superckl.me/job/BiomeTweaker/107/.With the latest build, everything should work fine, but you will see some
exceptions from BiomeTweaker. If those are really annoying you, you can do
two things.
- Enable light asm mode. This will cause BiomeTweaker to not do any
superclass resolution. This will break color overrides in some biomes, but
the errors will disappear.- Add the classes to the ASM blacklist. BiomeTweaker will ignore only
those classes when resolving superclasses. This is the best solution, but
you need to be able to find what classes are causing the crash.Again, you don't have to do either of these. The latest build will work
regardless. These will just remove the errors. I will close this issue when
I release version 1.0.—
Reply to this email directly or view it on GitHub
#25 (comment)
.
Hrm, the classes are not annotated with @SideOnly for whatever reason, which is why it slipped by me and I just load them on the server too. I guess I'll make a note to change that on my end, too - the enums are bad design anyway.