Bits And Chisels

Bits And Chisels

4M Downloads

Is there any know performance issues on servers? Noticed TPS was High and Saw this.

StoneLegion opened this issue ยท 7 comments

commented

I might be reading it wrong using spark profile

image

commented

I can confirm it's a real issue.

https://spark.lucko.me/DxZcMxT7E6

It looks like it's the Saving of the NBT data? Not 100% sure...

Examples of just boring old tps...

Before VV logsout:
image

VV Loggedout:
image

VV Logged Back in:
image

These were a a bunch seconds + before and after to count for spikes.

commented

I think this is just an issue with having a huge amount of bit blocks in a small area. I don't know what can be done in code other than just optimizing the function to save the NBT. The only thing I could think of doing that could make a dent is stop using indexof which wouldn't really help unless you have a lot of different types of bits in one block, but looking at the spark link you sent I don't think you do.

commented

I will let the person who created all the bits explain what he had done with his base.

commented

All bits have been removed from my base now. Sadly i do believe this mod is not ready to be used on multiplayer servers. If these issues arise with just one person using these blocks, what would happen if 10+ players start doing the same ?

commented

I mean, that's kind of like asking what would happen when lots of people spam chunk loaders. Personally, I don't think that many people will get to that level of usage, however I feel like it's not really that easy to optimize. I would still like to know how exactly you got the times so high to see if anything can be done about it.

commented

In a sane world chunk unloading would not block the main tick loop. Not sure what else there is to say, my code there is decently optimized and optimizing TACS is out of scope of this mod.