Blame (Fabric)

I updated this to the latest version on cruse and as soon as I updated it crashed

crash-2020-10-20_18.05.01-client.txt

Thank you for reporting this! Ok so it seems to be caused by my mixin conflicting with someone else's coremod. Do you have a modlist that I can check out and try to find the conflicting mod? It would also make it easier and faster if you are able to export the mod profile or let me know what modpack this is so I can download it.

Ok good news, it's just the java version currently shipped with GDLauncher. If you go to settings, java, turn off autodetect java path, and select your own java version, Blame should not crash GDLauncher anymore. Seems the java version they shipped has some bugs or something.

Ok after more tested, blame works perfectly with your mod pack with vanilla launcher. But blame alone in GDLauncher crash. wtf???

What launcher are you using? GDLauncher too?

Ok so I found it is this mixin that is crashing when ran on GDLauncher... oof.

Blame/src/main/java/com/telepathicgrunt/blame/mixin/JigsawPatternMixin.java

Lines 35 to 46 in 9b356c6

    
           @Dynamic 
        
           @Inject(method = "*(Lnet/minecraft/world/gen/feature/template/TemplateManager;Lnet/minecraft/world/gen/feature/jigsaw/JigsawPiece;)I", 
        
           		at = @At(value = "HEAD")) 
        
           private static void storeCurrentPool(TemplateManager templateManager, JigsawPiece jigsawPiece, CallbackInfoReturnable<Integer> cir) 
        
           { 
        
           	if(jigsawPiece instanceof SingleJigsawPiece && ((SingleJigsawPieceAccessor)jigsawPiece).getTemplateRL().left().isPresent()){ 
        
           		MissingNBTBlame.storeCurrentIdentifiers(new Pair<>(CALLING_POOL.getName(), ((SingleJigsawPieceAccessor)jigsawPiece).getTemplateRL().left().get())); 
        
           	} 
        
           	else{ 
        
           		MissingNBTBlame.storeCurrentIdentifiers(null); 
        
           	} 
        
           }

Thank you for letting me know so fast before it broke everyone else! Just use the previous version of Blame for now while I try and think of an alternative way to do this mixin to make missing nbt files be able to say what structure pool tried calling them

Actually, it is working with Multimc and Twitch launcher too. It's only GDLauncher that is failing. Huh. You can use the latest Blame but you have to use a different launcher if you do so. hmmm

Yeah can confirm it works for me

Amazing lmao. The issue the whole time was I was doing
import javafx.util.Pair; which only works on certain java versions I meant to use import com.mojang.datafixers.util.Pair; but I screwed up. This is 100% my fault. Fixed release coming shortly

blame-forge-1.16.3-1.4.6 is now approved on curseforge! Sorry about that everyone but thank you for being patient with me. I'm definitely not gonna make the mistake of importing javafx ever again lmao

@BedrockLegends

Hey, @BedrockLegends @V-boy, can either of you test this jar to see if this fixed the crash?
blame-1.16.3-1.4.6b.zip

	@Dynamic
	@Inject(method = "*(Lnet/minecraft/world/gen/feature/template/TemplateManager;Lnet/minecraft/world/gen/feature/jigsaw/JigsawPiece;)I",
	at = @At(value = "HEAD"))
	private static void storeCurrentPool(TemplateManager templateManager, JigsawPiece jigsawPiece, CallbackInfoReturnable<Integer> cir)
	{
	if(jigsawPiece instanceof SingleJigsawPiece && ((SingleJigsawPieceAccessor)jigsawPiece).getTemplateRL().left().isPresent()){
	MissingNBTBlame.storeCurrentIdentifiers(new Pair<>(CALLING_POOL.getName(), ((SingleJigsawPieceAccessor)jigsawPiece).getTemplateRL().left().get()));
	}
	else{
	MissingNBTBlame.storeCurrentIdentifiers(null);
	}
	}

Share to