Block Renderer [Forge/Fabric]

Block Renderer [Forge/Fabric]

3.3k Downloads

Rendering very dark items in animation mode causes the output gif to break

Tslat opened this issue ยท 4 comments

commented

As title - if you give the animation renderer a rather dark item to render, it fails to correctly output the gif.

What the thing looks like to try and render:
https://static.wikia.nocookie.net/adventofascension_gamepedia/images/1/18/Dustopia_Portal.gif/revision/latest?cb=20200126132439

What the animation renderer outputs:
Render

commented

Scratch that, it seems to happen to other items, even when not dark...

Original:
https://static.wikia.nocookie.net/adventofascension_gamepedia/images/e/e4/Gardencia_Portal.gif/revision/latest?cb=20200126132401

Render from mod:
Render 2

Worth noting, this occurs with auto loop turned on or off, but if it's on, I notice the auto loop takes a lot longer - sometimes going up to 60-80 instead of the normal values it gets to

commented

This one seems to break it entirely

https://static.wikia.nocookie.net/adventofascension_gamepedia/images/1/17/Iromine_Portal.gif/revision/latest?cb=20200126132404

Render output here:
2021-01-13_16 53 58_Iromine Portal

It's actually completely invisible, but this is what it looks like next to the other renders of the same block shape, for comparison:
image

commented

Seems to be an issue with the underlying gif writer (Or the metadata I provide), writing out the source data seperate show that individual frames are being renderered correctly.

This will probably be fixed with the migration from AWT (See #14).

I've provided a temporary stopgap where you can render the animation to a zip containing each frame. There should be tools available to convert the collection of png's into a gif (ImageMagick, ffmpeg, etc). Sorry whilst it's not ideal its the quickest 'fix' I can provide at the moment.

commented

Looks like the new GifWriter (from the AWT migration) will fix this.

The code still needs some cleanup but hopefully I can finish up the migration this weekend and release 1.5.0.

Images

Iromine Portal
Dustopia