[1.20.1] Overworld surface rules corrupting worlds
Neko2n opened this issue · 8 comments
Blueprint seems to be causing an issue where the overworld surface rules in a world's level.dat slowly gets larger and larger until the NBT is too large to read (has depth greater than 512). Here's a screenshot of how the NBT looks on a world that is crashing:
Upon making a new world this pattern seems to still be present, but there are less recursions with the depth only reaching 4 or 5. Here's what that looks like:
A corrupted world looks like this in the logs:
latest.log
And finally here's a copy of the corrupted level.dat:
https://drive.google.com/file/d/1bZdR5i4QrWmayJ5ErYDTN_fiSLevsEMM/view?usp=sharing
(Couldn't upload directly to github as they don't support the .dat file type)
I have 300+ other mods installed alongside blueprint as well as some of the indev versions of other abnormal's mods, so it's very possible the issue doesn't actually come from blueprint. The most notable mod installed is terrablender, which has been reported to have had this same issue with citadel in the past: LunaPixelStudios/Better-MC#1415 (comment)
I've been seeing level data corruption issues very frequently recently, but Blueprint code hasn't changed in a while, so I suspect something new is making the issue happen or much more common than before. I've only seen this issue occurring in Connector/Fabric environments lately, which probably explains the significant increase in the frequency of level.dat corruption because Blueprint is not designed for that platform.
Anyway, I'm not very concerned with the cause or who is at fault because it's very bad to see user worlds getting corrupted, and I want to fix it myself as soon as possible.
I will fix this issue and likely all future Blueprint level.dat issues by stopping Blueprint from serializing its dimension modifications. Normally Blueprint handles the serialization fine, but I suspect something is forcing Blueprint to not reset its serialized modifications.
Fortunately, user worlds are recoverable if the level.dat dimension data gets reset to vanilla.
fyi the server I was running that originally contained this world was not running connector. I only have connector installed on my client for some client-sided mods like presence footsteps and wakes. The server was not printing logs properly, though, so I had to download the world files and run it in singleplayer to get readable log data.
Also, yes, I was able to fix the issue by deleting the old world’s overworld and end dimension surface rules and replacing them with surface rules from the newly generated world. I did this through NBTStudio.
I tried to reproduce the issue you're getting with similar conditions and got a similar problem.
I can't reproduce the blueprint:transient_merged surface rule containing other blueprint:transient_merged surface rules, so I'm unsure why that's happening. Anyway, that shouldn't be possible unless a mod other than Terrablender is doing something weird.
Potential Fix:
@Neko2n I'd appreciate it if you could try the following steps to see if the NBT stops growing with each world reload with your mod set.
Step 1: Reset your surface rules to vanilla.
Step 2: Use this experimental Blueprint version instead.
Step 3: Reload the same world many times and see if the surface rule NBT no longer grows.
In a newly generated world:
Ported the settings over to the corrupted world and reloaded the world three times. Each time it loaded up without fail.
This seems to have fixed the issue :)
