Add support for 1.18.2
SecretlyJealous opened this issue · 11 comments
1.18.2 has been released in case you didn't know, would be nice if you could make the mod work for it whenever you get the time
Seems like an update of https://github.com/zml2008/confabricate is required. There's a "Begin update for 1.18" commit from four days ago, so I'm guessing it's WIP and we'll just have to wait until it's released.
Ah yes I think a lot of the mods that don't work have this dependancy in fact. Thanks for the update on that.
NightEule5 commented LambdAurora/LambdaBetterGrass#45 (comment) "The mixin for net.minecraft.class_3304 which maps to net.minecraft.resource.ReloadableResourceManagerImpl is failing. The method method_14475, which maps to addPack in 1.18.1, is missing from 1.18.2's mappings. It must've been removed"
NightEule5 commented LambdAurora/LambdaBetterGrass#45 (comment) "The mixin for net.minecraft.class_3304 which maps to net.minecraft.resource.ReloadableResourceManagerImpl is failing. The method method_14475, which maps to addPack in 1.18.1, is missing from 1.18.2's mappings. It must've been removed"
Uh, this isn't LambdaBetterGrass, this is Bobby. That comment has nothing to do with this mod.
And no, LambdaBetterGrass doesn't use Confabricate. There's like zero connections between Bobby and LambdaBetterGrass.
Bobby works fine on 1.18.2 if you drop in a newer version of Confabricate.
https://repo.stellardrift.ca/repository/snapshots/ca/stellardrift/confabricate/3.0.0-SNAPSHOT/confabricate-3.0.0-20220303.200452-4.jar
Seems like an update of zml2008/confabricate is required. There's a "Begin update for 1.18" commit from four days ago, so I'm guessing it's WIP and we'll just have to wait until it's released.
You can still use it from the snapshots repository; specifically 3.0.0-SNAPSHOT. See the usage instructions for the snapshots repository.
Bobby works fine on 1.18.2 if you drop in a newer version of Confabricate. https://repo.stellardrift.ca/repository/snapshots/ca/stellardrift/confabricate/3.0.0-SNAPSHOT/confabricate-3.0.0-20220303.200452-4.jar
Seems like an update of zml2008/confabricate is required. There's a "Begin update for 1.18" commit from four days ago, so I'm guessing it's WIP and we'll just have to wait until it's released.
You can still use it from the snapshots repository; specifically
3.0.0-SNAPSHOT. See the usage instructions for the snapshots repository.
See, what's weird to me is that with this the game does launch and I can get into the server I play on. But, after playing in the world for a few seconds, it just crashes. I took out all the other mods I use and only had the bare minimum, but got this: using bobby 3.1
crash-2022-03-11_13.01.01-client.txt
my mods are : bobby 3.1.0, cloth 6.2.57, confabricate 3.0.0 (snapshot you sent), fabric api 0.47.10, mod menu 3.1.0, and sodium fabric 0.4.1+build15. Are there conflicting mods? Or is it an issue with confabricate alone?
That's... weird. It works for me, but maybe Bobby does need some additional changes. Not sure.
Yeah I just tested a whole different array of mods, and ran confabricate alone. It seems to be an issue with bobby itself running with the new confabricate, do you think I should create a new issue? Or keep to this thread?
That's... weird. It works for me, but maybe Bobby does need some additional changes. Not sure.
Turns out Confabricate doesn't do all that much which Bobby depends on. So I've replace the strong dependency with a soft one, falling back to using Configurate (the Minecraft independent lib behind Confabricate) directly (77d0035).
And then a small amount of extra work was needed to make Bobby itself work with 1.18.2 (b1cc5d8).
Released as Bobby 3.1.1 to GitHub, Modrinth and (once approved) CurseForge.