Boss Health Regain

Boss Health Regain

551k Downloads

So this happened

Kuggle01 opened this issue ยท 6 comments

commented

https://bytebin.lucko.me/yWpmY9ukIZ The game just crashed when I punched a baby skeleton from Born in choas. I have no idea how or why this happened???

commented

Yeah that is what I was going to report too.

commented

Yeah, latest SG seems to have changed a couple methods that were used in this mod? DataResource.trait(ResourceLocation) doesn't seem to be correct anymore for some reason. I just looked through SG's code and it looks like that DataResource class was deprecated in favor of the one in the API package. Not sure why it doesn't work though, looks like the deprecated one just inherits the API class, which has the method you were using. Probably something on SG's end, incorrectly extending the API class to account for older code but accidentally breaking it instead.

Either way, it's probably best to switch this mod's code to use the API.

commented

A lot of it has to do with born in chaos too. During my testing it seems there are some fairly large render and thread no nos. I opted to remove BiC until further notice. That might be more of a fault of MC-Creator than BiC though possibly I could be wrong but since I have little experience coding I just ask a dev who really knows their stuff when it comes to render and thread issues.

commented

two more crash reports for what I believe is the same issue but i'm not using born in chaos.
What I specifically noticed is that I swing at an enderman with a silent gear pickaxe and the server crashed. later on, another player swung at a bat with a copper saw from silent and the server crashed again. let me know if you think this should be reported in the silent gear mod github
https://pastebin.com/Z7Ck2szu

https://pastebin.com/jBf5BTrJ

commented

It has been reported and attempts has been made to alleviate it on the SG side.
Issue
First commit
Second commit
Third commit

commented

Should be fixed in latest versions