Possibly Null Recipes
Shahelion opened this issue ยท 12 comments
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.SpecialFloatingFlowerRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.CompositeLensRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.LensDyeingRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.ManaGunLensRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.ManaGunRemoveLensRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.ManaGunClipRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.HelmRevealingRecipe' > 1xitem.manasteelHelmReveal@0
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.TerraPickTippingRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.RegenIvyRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.SpellClothRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.AncientWillRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.CosmeticAttachRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.CosmeticRemoveRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.PhantomInkRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.AesirRingRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.KeepIvyRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.BlackHoleTalismanExtractRecipe' > null
[19:27:31] [Client thread/INFO] [FML]: DRAGONAPI: Found a modded recipe registered in pre-init! This is a design error, as it can trigger a Forge bug and break the recipe! Recipe=Unknown 'vazkii.botania.common.crafting.recipe.LensDyeingRecipe' > null
This is reported by dragonapi.
Which version? If 1.8-248 then there is no problem here as it's only dragonAPI protesting this. Otherwise a 'vanilla' console doesn't show or throw out problems with anything.
Dragon-API has called attention to quite a few things in other mods that are not normally noticed. And version 249.
This is occurring because the blocks/items/etc are being initialized in the Pre-Init stage, and for whatever reason the recipes are being register inside of the constructors of the blocks. For example:
public ItemManaGun() {
super();
setMaxDamage(COOLDOWN);
setMaxStackSize(1);
setNoRepair();
setUnlocalizedName(LibItemNames.MANA_GUN);
GameRegistry.addRecipe(new ManaGunLensRecipe());
GameRegistry.addRecipe(new ManaGunRemoveLensRecipe());
GameRegistry.addRecipe(new ManaGunClipRecipe());
RecipeSorter.register("botania:manaGunLens", ManaGunLensRecipe.class, Category.SHAPELESS, "");
RecipeSorter.register("botania:manaGunRemoveLens", ManaGunRemoveLensRecipe.class, Category.SHAPELESS, "");
RecipeSorter.register("botania:manaGunClip", ManaGunClipRecipe.class, Category.SHAPELESS, "");
}This is easy to fix, of course, but I am quite curious as to why it's like this.
dragonAPI has a history of whining about things that are largely irrelevant. they dragonapi should be specifying which forge bug that this possible brings up and what happens when it is invoked
plenty of other mods I've seen register recipes in preinit
botania just does it this way because it does :P
It probably isn't specifying which error because it would have to do so with every error, and this was only a small fraction of it. Forestry, Witchery, and several other mods also have these messages.
DragonAPI complains about it because Extra Utilities registers recipes in pre-init IIRC, and it was breaking recipes in both RotaryCraft AND Extra Utilities, specifically the magical wood recipes.
The "null" in the output side of the recipe is not necessarily an error; it likely only means that the recipe output is dynamic based on the inputs, which is fine.
However, yes, the custom-class recipes should not be registered in preInit. Any other mod initializing the OreDict will trigger the Forge replace-all-recipe-objects-withShaped/ShapelessOre bug and, should the special recipes involve any default-oredicted items, will break those recipes. ExU Magical Wood is one such example.
Nonconstructive contributions are not welcome.
DragonAPI checks the things it does because so many allegedly well-designed mods do so many obviously unsafe or ridiculous things that cause all sorts of problems, be it registering smelting recipes with null inputs, or registering items to the OreDict that crash on handling/rendering/naming (or simply registering null), or deleting vanilla items, or sending ItemStacks of null into the dungeon loot tables, or calling IWorldGenerators with a null world argument. Because I so often get blamed for these issues that are nonetheless entirely on the other mod's end, I have put in checking to make the actual issue source clear.
I apologize for my statement, it was presumptive and brash.
Back on topic, wouldn't it be better reporting the bug to forge? or is it just a quirk with how it works?
Yes, but Forge is downright glacial in their fix response time - we are often lucky to see fixes in the same MC version - and almost every time I point out an error in their system I am laughed off or otherwise ignored. Examples: Null-item itemstack check; ItemBlock ID removal behavior; various events I asked for.
@reika could you throw some light on this please good sir?
Tagged the wrong person booker. :P @ReikaKalseki