Botania (Fabric/Quilt)

Botania (Fabric/Quilt)

5M Downloads

Hopperhock doesn't pickup witherstar

MakerTim opened this issue ยท 24 comments

commented

The hopperhock doesn't pick up the wither star, after its dropped from the wither
it does pick it up after i drop it

so it seemed a bit weird, so i report it ๐Ÿ˜•

Forge 2121
Botania r1.9-337
java 1.8
Linux server, Windows client

commented

Fixed by b7d88a5, coming in 1.17.

Only took 5 years! ๐ŸŽ‰

commented

As far for my debugging skills go,
http://i.imgur.com/TdRBGlD.png
it seems a item.item
just like every other in minecraft thats dropped, i guess its nbt that makes it explosion proof and all
not sure, im no expert on this

commented

hover over the name component for the netherstar, it gives you the entity id.

commented

http://i.imgur.com/3lfkwRW.png
Type: Item (1)

I did also a /entitydata @[r=10,type=!Player] {}
http://pastebin.com/tHkvuPWq
but i see nothing that makes it different for me

commented

That's just the UUID of the entity for the World isn't it. I don't think you'll be able to figure out if some mod is changing the EntityItem class of the Nether star item this easily. Even if they did change it they would have to extend the class for it to be even dropped in world no? I'm assuming there's some event being called and cancelled by another mod for some reason but i'm not entirely sure and I can't look into it myself right now. Hell I don't even know if there even is an event being fired this is just my guess on the whole thing.

commented

we just did tell if it's an EntityItem, which it is. Bleh.

commented

I looked over Botania's code it just checks for nearby EntityItems so it should be working, no idea why it isn't.

commented

The Vacuum Chest, of enderio, is working with the entity
so there for, it should be possible somehow i figure

commented

Okay, the diffrence is
getEntitiesWithinAABB - botania
vs
selectEntitiesWithinAABB - enderio

so somewhere is there a difference between them

commented

Shouldn't matter

commented

Can you reproduce with just botania

commented

https://puu.sh/s8Ace.mp4
The one on the left is from a wither, right dropped

still works on my test bench where i got only Baubles (1.3.2) and Botania (337) *and ofc Forge (2121)

commented

what other mods are present?

commented

Wither farm is nearby

Collectible range of Hopperhock flower ??

commented

@yrsegal
http://pastebin.com/XMghCdG8
in short, a lot

EDIT: use pastebin for listing, layout of viewing was not working in github

commented

@jomin398 it is getting the item when i drop it AND its collecting the shader thingy of Immersive Engeneering, thats dropped at the EXACT same spot
so on that note, i will assume that it is the hopperhock and not my setup

commented

It might be that the item for the nether star is getting replaced by a custom entity.

commented

The Wither drops an EntityItem with a -6000 age, which seems to be caught by this.

age < 60 + slowdown will always be true.

EDIT: Possible fix: use Entity.ticksExisted instead of EntityItem.age? There's a variety of strange cases where age is "wrong", such as this and when items are dropped by a creative player.

commented

This issue is stale because it has been open for a while with no activity. Remove stale label or comment or this will be closed soon.

commented

This is still an issue in the latest version of Botania.

commented

Correct. Can't really be fixed until #3507 is done, which will have to wait til 1.17 since it affects world compatibility.