Hopperhock doesn't pickup witherstar
MakerTim opened this issue ยท 24 comments
The hopperhock doesn't pick up the wither star, after its dropped from the wither
it does pick it up after i drop it
so it seemed a bit weird, so i report it ๐
Forge 2121
Botania r1.9-337
java 1.8
Linux server, Windows client
Fixed by b7d88a5, coming in 1.17.
Only took 5 years! ๐
As far for my debugging skills go,
http://i.imgur.com/TdRBGlD.png
it seems a item.item
just like every other in minecraft thats dropped, i guess its nbt that makes it explosion proof and all
not sure, im no expert on this
http://i.imgur.com/3lfkwRW.png
Type: Item (1)
I did also a /entitydata @[r=10,type=!Player] {}
http://pastebin.com/tHkvuPWq
but i see nothing that makes it different for me
That's just the UUID of the entity for the World isn't it. I don't think you'll be able to figure out if some mod is changing the EntityItem class of the Nether star item this easily. Even if they did change it they would have to extend the class for it to be even dropped in world no? I'm assuming there's some event being called and cancelled by another mod for some reason but i'm not entirely sure and I can't look into it myself right now. Hell I don't even know if there even is an event being fired this is just my guess on the whole thing.
I looked over Botania's code it just checks for nearby EntityItems so it should be working, no idea why it isn't.
The Vacuum Chest, of enderio, is working with the entity
so there for, it should be possible somehow i figure
https://github.com/SleepyTrousers/EnderIO/blob/11e874b89e05008dfd7cf2c25566da4efa1215ff/src/main/java/crazypants/enderio/machine/vacuum/TileVacuumChest.java#L89
Looked at EnderIO, where it does pickup the item
and there they check on EntityItem class
I can be blind, but doesnt they both use the same method?
https://github.com/Vazkii/Botania/blob/e38556d265fcf43273c99ea1299a35400bf0c405/src/main/java/vazkii/botania/common/block/subtile/functional/SubTileHopperhock.java#L69
Okay, the diffrence is
getEntitiesWithinAABB - botania
vs
selectEntitiesWithinAABB - enderio
so somewhere is there a difference between them
Wrong version of enderio, it's the same function. https://github.com/SleepyTrousers/EnderIO/blob/1.10/src/main/java/crazypants/enderio/machine/vacuum/TileVacuumChest.java#L101
https://puu.sh/s8Ace.mp4
The one on the left is from a wither, right dropped
still works on my test bench where i got only Baubles (1.3.2) and Botania (337) *and ofc Forge (2121)
@yrsegal
http://pastebin.com/XMghCdG8
in short, a lot
EDIT: use pastebin for listing, layout of viewing was not working in github
@jomin398 it is getting the item when i drop it AND its collecting the shader thingy of Immersive Engeneering, thats dropped at the EXACT same spot
so on that note, i will assume that it is the hopperhock and not my setup
It might be that the item for the nether star is getting replaced by a custom entity.
The Wither drops an EntityItem with a -6000 age, which seems to be caught by this.
age < 60 + slowdown
will always be true.
EDIT: Possible fix: use Entity.ticksExisted instead of EntityItem.age? There's a variety of strange cases where age is "wrong", such as this and when items are dropped by a creative player.
This issue is stale because it has been open for a while with no activity. Remove stale label or comment or this will be closed soon.
Correct. Can't really be fixed until #3507 is done, which will have to wait til 1.17 since it affects world compatibility.