Botania (Fabric/Quilt)

Botania (Fabric/Quilt)

5M Downloads

Golden Crown not preventing death from Blood Magic Sacrificial Knife, results in loss of items

vectorman1 opened this issue ยท 11 comments

commented

Reproduction steps are:

  1. Get yourself an altar.
  2. Equip a Golden Crown bauble.
  3. Get a Sacrificial Knife and right-click like mad until you die.
  4. You see 2 messages indicating "The Golden Laurel Crown Shatters, as it saves you from death.", however you're at your spawnpoint, with all items lost, except the baubles.
commented

I'm fairly sure it is something on Way's side and he is aware of it.

commented

I don't believe that it is intended to prevent death by suicide? That would break Blood Magic, alot.

commented

I'm fairly sure it is something on Way's side and he is aware of it.

I hope it's not a bad thing I sent in an Issue on the Botania side in that case. If you want, I am going to close.

I don't believe that it is intended to prevent death by suicide?

Lexica Botania states it prevents 'death' regardless of the cause.

That would break Blood Magic, a lot.

No, it wouldn't. You can make a beacon of regeneration in the vicinity of the altar anyways, doesn't make a difference. The case here is that I got too click-happy and I had to recover all my items.

commented

BM does some weird stuff with directly setting health instead of damaging the player directly, I think this is a BM thing more than Botania https://github.com/WayofTime/BloodMagic/blob/1.9/src/main/java/WayofTime/bloodmagic/item/ItemSacrificialDagger.java#L132-L138

commented

I looked through the code myself and made similar observations. Obviously, there needs to be made an exception from one of the mods, be it Blood Magic or Botania. Considering it's Botania that's supposed to prevent death could there be a way to implement a watchdog of some sort that looks if the player health is about to be forced to 0 by Blood Magic methods?

commented

related, i have managed to kill myself twice in a row, spawning 2 graves, by spamming the sac knife in 1.7 with massive regen active

one grave had all of my items, the 2nd grave had a duplicate sac knife

commented

The duplicate knife is a know issue.

And I doubt about bypassing BM without a bit of hackers. This was put in place to stop people from breaking BM balance in regards to zerg rushing the alter.

commented

Couldn't the crown check if the source of death is Blood Magic (it has its own damage type for its debuff upon respawn) and if it is, just not cancel the death event?

commented

that's a hack, the crown still wouldn't be doing what it's advertised to do

commented

Better would be for BM to do the check...

commented

@bookerthegeek From my understanding, the "no Zerg Rushing" mechanic Blood Magic uses is Soul Fray, which significantly lowers your LP output shortly after dying. It's there to prevent players from placing a bed right next to their altar, then repeatedly killing themselves and respawning with full health.

I wouldn't say that the Golden Laurel Crown preventing death would break Blood Magic. Anything that adds Regeneration and/or Saturation already does a good job of that. Frankly the Golden Laurel Crown is too expensive to be exploited for a few extra hearts worth of LP.

I would guess that Blood Magic uses direct health sets to bypass armor, but someone would have to ask one of their developers to know for certain.