Botania (Fabric/Quilt)

Botania (Fabric/Quilt)

5M Downloads

FPS loss when holding Wand of the Forest

codewarrior0 opened this issue ยท 6 comments

commented

VisualVM Sampler output:

image

Example build:

image

While holding a Wand of the Forest, my FPS drops from 45 to 9. This build has twelve Mana Spreaders equipped with Bore Lenses and two with Messenger Lenses.

Testing in a creative world isolates the problem to Mana Lenses: Twenty Mana Spreaders with Bore Lenses drops FPS from 110 to 55. When the bore lenses are removed, there is no FPS drop when holding the Wand.

Running Botania f9f56bd with Forge 13.20.0.2252

commented

Sampler output from creative world testing in dev environment:

image

commented

No, I am not using composite lenses. Yes, it's weird that it's hitting that codepath, but the problem won't be addressed there - the FPS loss will still affect composite lenses. In fact, I switched all of the lenses out for composite ones and the problem got even worse!

commented

wait wut I swear I fixed this in 1.10 branch...did it get lost in the merge?

commented

@williewillus I was thinking the exact same thing

commented

That's not the right fix. The problem still exists when using composite lenses.

commented

Actually, never mind. The FPS drop is still there with composite lenses, but it's not nearly as bad as before.