Botania (Fabric/Quilt)

Botania (Fabric/Quilt)

5M Downloads

[1.12.2] Most recently placed flower does not render properly

Shahelion opened this issue ยท 11 comments

commented

Forge version: 2555
Botania version: 350
Link to crash log: N/A

Steps to reproduce:

  1. Get some Pure Daisies
    2: Place them down one at a time

What I expected to happen:
The flowers to render properly from the start.

What happened instead:
The Flower renders as a checkered purple and black block, with the hitbox of the flower. When I place a second flower, it also renders incorrectly, but the first flower is then fine.

After placing the first flower:
2017-11-30_11 57 29
After placing the second flower (note that the first is now rendering properly):
2017-11-30_11 57 36

Forcing a re-render does not fix it.

commented

Followup: After breaking and re-placing both a few times, they now both refuse to render at all, regardless of order.

Followup 2: A complete reload of the game renders them all properly.

commented

can you do it with botania alone?

commented

I can't speak to his setup, but I have the same issue. It seems to be caused by Fancy Block Particles. Disabling it fixed the issue.

commented

Ohhhh that's the mod that does that. Couldn't remember what mod was making everything 3d but it was fun so I just left it. That makes sense, though.

commented

It's because the flower needs data from the tile entity to render properly. How does this mod handle something like the colored beds or banners, which need the same?

commented

I can't speak to the technical side of things (which is probably what you need admittedly), but I just tested it and the beds and banners work as intended.
example

commented

Follow up: Don't know if this helps, but I noticed the beds/banners use metadata/damage values (minecraft:banner:1) and the pure daisy uses a tag (botania:specialflower.withTag({type:"puredaisy"}))

commented

banners with custom patterns use NBT though

commented

I only see unpatterned banners in that image. It might be that each color base banner is a fallback, which botania flowers do not have. Then again i could be entirely off the mark.

commented

New to 1.12, didn't know about that. But I had also been posting an issue on Mekanism's repo because of a crash caused by placing tanks and pipes. Turns out FBP caused that too. So I'm guessing it's a problem on their end with placed blocks not having nbt data or something like that.

commented

closing as it's not a botania issue.

basically, the model needs an ExtendedBlockState to work properly, which itself needs the TE to have the subtile information set