Flügel Tiara Overrides Extra Utilities' wing rings
SimulatorSia opened this issue · 11 comments
Forge version: 12.2-14.23.1.2582
Botania version: all latest all the way down past 1.7.10 but I'm currently on 1.12.2
What I expected to happen: have infinite flight while wearing the Extra Utilities flight rings and a Flügel Tiara
What happened instead: the Flügel Tiara runs out of flight overriding Extra Utilities, also the Flügel Tiara named "Flügel" makes a the left wing from Extra Utilities not render.
https://i.imgur.com/ZEZcbH7.png
(Side issue) Soujourner's sash doesn't let you bounce on slime blocks, CFM's trampoline or diving board.
These issues have been in Botania as long as I can remember, I never got around to saying something about them till now.
This is because the angel ring and the tiara end up fighting over player.capabilities.allowFlight
. The angel ring wants it on, the tiara wants it off.
This proposed Forge feature would allow for a solution, but I don't know if there's any progress on it: MinecraftForge/MinecraftForge#3931
oh, I'm sorry for sounding insensitive >.<
I didn't know it was an issue of competing usage of .class'
What about the other issues? One wing not rendering, soujourner's sash not letting you bounce on slime blocks, CFM's trampoline or diving board.
You know you could solve the first issue by adding code to disable Flügel Tiara entirely when the Wing Ring is present in the inventory...
"conflicting creative flight" is an issue faced by every mod that adds creative flight -
the linked forge PR is a likely solution but it seems pretty dead. if someone doesn't pick it up I might get around to it sometime ^tm but until then just don't have conflicting items together
I'm sorry, I didn't know I wasn't supposed to add multiple in one report. What should I do?
(Edit) you guys aren't getting me, you could solve it without even tampering with the "player.capabilities.allowFlight" class.
What I propose is whenever there is an Extra Utilities ring in a players inventory, a Flügel Tiara LITERALLY deletes, and another item takes it's place with the same name and texture but has no uses. And when a ring exits the inventory, the Flügel Tiara ghost item deletes, and a real active one takes its place.
Well that sounds like a recipe for bugs
Also hardcoding behavior for other mods' items is stupid