Botania (Fabric/Quilt)

Botania (Fabric/Quilt)

Mods
5M Downloads

Manufactory Halo tries to intercept completed "fake" recipes from Thaumcraft's Thaumatoriums, and crashes

Reassembly opened this issue ยท 0 comments

commented

Version Information

Forge version: 1.12.2-14.23.4.2705
Botania version: r1.10-354
Thaumcraft version: 1.12.2-6.1.BETA23

Further Information

Link to crash log: https://paste.dimdev.org/damuwuloxa.mccrash
Steps to reproduce:

  1. Build a Thaumatorium from Thaumcraft.
  2. Load the Thaumatorium with sufficient ingredients to execute many alchemy crafting cycles. Provide sufficient essentia for crafting to the Thaumatorium with pipes or a transfuser.
  3. Activate the Thaumatorium, and let it begin crafting with the ingredients and essentia you have provided. Close the Thaumatorium's interface, and let it continue running.
  4. Hold a Manufactory Halo, and open its embedded Crafting Table interface. Do not attempt to craft anything with it - just wait.
  5. When the Thaumatorium completes a crafting cycle, if the Halo's Crafting Table is open, the game will crash.

What I expected to happen:

Crafting Halos should be intercepting crafting events executed only with either a 2x2 or 3x3 crafting grid, either from a real Crafting Table or from its own embedded Crafting Table, for potential saving to a memory slot in the Halo's interface. (Additionally, Halos probably should only intercept crafting events directly executed by the player holding the Halo, and not just any crafting events happening nearby.)

What happened instead/Theory:

Thaumcraft defines certain "fake" recipes for use only with specialized crafting devices (Thaumatoriums/Crucibles, Arcane Workbenches, etc.), which cannot be executed with a vanilla Crafting Table. It appears that Crafting Halos will attempt to intercept and record these "fake" recipes, if they occur nearby (even as part of an automated system). However, it appears that since the inputs to these recipes cannot be properly typecast into normal 2x2/3x3 Crafting Table recipe inputs, simply having a Halo's crafting interface open while a fake recipe completes results in an uncaught typecasting error, leading to a game crash.

It is possible that this issue is not exclusive to Thaumcraft+Botania, but may also occur with other mods which define this sort of pseudorecipe for use with specialized crafting devices, if they also support any degree of automation of those recipes.