Botania (Fabric/Quilt)

Botania (Fabric/Quilt)

5M Downloads

Drum of the Wild always harvests same blocks

fraenkelc opened this issue ยท 0 comments

commented

Version Information

Forge version: 14.23.5.2808
Botania version: r1.10-359

Further Information

What I expected to happen:
if the number of harvestable blocks exceeds 32 then Drum of the Wild should pick random blocks to harvest on each mana burst.

What happened instead:
Drum of the Wild always picks the same blocks to harvest since the Random it uses is always initialized with the same block coordinates.

See https://github.com/Vazkii/Botania/blob/fb8ebd8ca7e4dd24a1c93bf2a92ea4f93fee98fe/src/main/java/vazkii/botania/common/item/ItemGrassHorn.java#L110, https://github.com/Vazkii/Botania/blob/fb8ebd8ca7e4dd24a1c93bf2a92ea4f93fee98fe/src/main/java/vazkii/botania/common/item/ItemGrassHorn.java#L125