Botania (Fabric/Quilt)

Botania (Fabric/Quilt)

5M Downloads

Hard-coded ordinal number suffixes

Regnander opened this issue · 2 comments

commented

Version Information

Forge version: 1.12.2-14.23.5.2824
Botania version: r1.10-360

Further Information

Link to crash log: none

Steps to reproduce:

  1. Acquire a copy of Lexica Botania
  2. Look at the cover or go to the index page to find the edition number.
  3. Compare it to the format of botaniamisc.edition=%s Edition to find that the ordinal number suffix in said string cannot be removed or changed.

What I expected to happen:

I'm currently working on a Swedish translation of this mod and when I translated the botaniamisc.edition=%s Edition string I was expecting the variable (%s) to only contain a number so I translated it to "Utgåva nr. %s" (which is Swedish for "Edition no. %s").

What happened instead:

While testing the translation I noticed how the number ended with "th", so I scanned through the code and realized that the suffix is hard-coded, producing an unexpected result:

a

Being able to disable the suffix would be nice, as having an English ordinal number makes no sense in a non-English language. An alterantive way would be to translate every ordinal number, but it is a rather daunting task given how each language may work differently.

While I'm on the subject, instead of inserting botaniamisc.devEdition into the variable of the botaniamisc.edition I'd recommend to replace botaniamisc.edition with botaniamisc.devEdition while in dev mode (and change botaniamisc.devEdition to "Writer's Edition") as it would make it much easier to translate since translators wouldn't have to take into account that botaniamisc.edition must look good in both dev mode and non-dev mode.

PS. I know that I can leave botaniamisc.edition empty to avoid this altogether, but I think the book looks so empty without it (and besides, removing it would create a large gap and slightly mess up the layout).

commented

This issue is stale because it has been open for a while with no activity. Remove stale label or comment or this will be closed soon.

commented

Bump