Mana Enchanter Doesn't Use Apotheosis Tomes As Valid Enchanting Book
Numorphan opened this issue ยท 3 comments
Version Information
Forge version: 2836
Botania version: r1.10-361
Apotheosis version: 1.9.3
Further Information
Steps to reproduce:
- Place any number of apotheosis tomes (of the right type) in the mana enchanter.
- Activate the mana enchanter.
- Nothing happens.
- Add a regular book.
- Activate it.
- The regular book's first enchant will be applied, with all the tome's enchants ignored.
What I expected to happen:
The mana enchanter should treat the tome as a regular enchanted book.
What happened instead:
When using an Apotheosis tome (of Helmets, Weapons, etc) in the Botania mana enchanter, the mana enchanter will ignore the tome and not apply the enchant to the central item.
The Apotheosis book happens to extend ItemBook
so you could mayyyybe check for || item.getItem() instanceof ItemBook
here https://github.com/Vazkii/Botania/blob/94ed40a955d13c637dbe505a4ddc2fefcbf5f4fb/src/main/java/vazkii/botania/common/block/tile/TileEnchanter.java#L129
there's no way to really tell if something is an "enchanted" book without hardcode checking for the vanilla one.