Can't critical-hit with sashes on

Question

Can't critical-hit with sashes on

Alwinfy opened this issue 5 years ago · 5 comments

Alwinfy commented 5 years ago

Steps to reproduce:

Grab a diamond axe
Jump and hit a mob as you're falling (mob should take 150% and throw off crit particles)
Grab a full mana ring and Planestrider's Sash, equip both
Jump and hit a mob as falling again

What I expected to happen: Critical hit

What happened instead: nop

Alwinfy commented 5 years ago

bump

Alwinfy · Answer 1 · 2020-03-03T16:46:46.000Z

Update: Pretty sure the crit code actually checks fallDistance > 0, and the sashes set fallDistance negative to achieve their effects. Not sure how to fix.

github-actions · Answer 2 · 2020-07-28T00:08:04.000Z

This issue is stale because it has been open for a while with no activity. Remove stale label or comment or this will be closed soon.

Hubry · Answer 3 · 2020-09-05T17:56:49.000Z

Can't seem to repro on 1.16.2, probably no longer an issue

github-actions · Answer 4 · 2020-05-03T00:03:00.000Z

This issue is stale because it has been open for a while with no activity. Remove stale label or comment or this will be closed soon.

Share to