Corporea index doesn't localize
gamma-delta opened this issue ยท 2 comments
Mod Loader
Fabric
Minecraft Version
1.19.2
Botania version
1.19.2-436-FABRIC
Modloader version
Quilt Loader 0.17.7 / Quilted Fabric API 4.0.0-beta.24+0.68.0-1.19.2
Modpack info
Spooled (by Moss)
The latest.log file
(there is no crash)
Issue description
Corporea indices can't request anything from the network with their localized name.
Given this setup (there's 60 obsidian in the barrel):
- Requesting
obsidian
won't find any - Requesting
block.minecraft.obsidian
will get you 1 obsidian - Same with requesting
*
Steps to reproduce
- Make a minimal corporea network with a storage chest and an index
- Try to request something
- Find it only works with the I18n string, not the translation
Other information
I'm sorry, Artemis, for being mean to you.
The issue here is for multiplayer games, where the language setting of the client might not necessarily match that of the server. Currently corporea index requests are mostly handled on the server side, including the returned message. Things will get very tricky when the client's language is supposed to be used, as the client doesn't know what items exist in the corporea network and the server doesn't know what language the client actually uses. As a result, default item names would need to be resolved on the client, but renamed items and items with dynamic names (something like "Fluid Tank (Water, 1000mB)") will need to be matched on the server. The issue is that not only does the server not know a client's language setting, it might not even know that language at all.