Botania (Fabric/Quilt)

Botania (Fabric/Quilt)

5M Downloads

Corporea Crystal Cube causing ticking block entity crash

MissCapy opened this issue ยท 4 comments

commented

Mod Loader

Fabric

Minecraft Version

1.20.1

Botania version

1.20.1-441-fabric

Modloader version

Fabric Loader 0.14.24 + API 0.90.7

Modpack info

No response

The latest.log file

https://pastebin.com/UuBZSUBV

Issue description

The title is pretty much it. attempting to measure the amount of any item in a corporea system with a crystal cube causes the game to crash.

Steps to reproduce

Place down a master corporea spark on a corporea brick
put a regular corporea spark on a chest
put any item in the chest
place down a corporea crystal cube
set the corporea crystal cube to read whatever item you put in the chest
client should crash basically immediately due to a ticking block entity

Other information

I first ran into this when I ported my 1.19 world to 1.20.1. several troubleshooting steps later, I created a fresh install, with just Botania, Patchouli, and Trinkets. I made a new creative world and attempted the steps above, which still produced the crash described above. the linked log file is from said creative world. the fully modded client as well as the fresh install ran completely fine right up until I right clicked the corporea crystal cube to tell it what item to read.

commented

Can confirm. https://mclo.gs/pxZfaQg
I can't actually get into my world without crashing once it's loaded in :c

commented

Might have accidentally been introduced with the changes in 66680dd.

commented

Upon further inspection, it's probably related to

builder.add(item.toStack((int) inv.simulateExtract(item, rem, null)));
not passing the outer transaction to simulateExtract.

commented

ugh, this transaction api sucks.