Botania (Fabric/Quilt)

Botania (Fabric/Quilt)

5M Downloads

Guardian of Gaia music plays on the "record" channel

Partonetrain opened this issue ยท 3 comments

commented

Mod Loader

Both Fabric and Forge (I confirm that I have tested both loaders and will specify both loader versions below)

Minecraft Version

1.20.1

Botania version

1.20.1-443

Modloader version

0.15.3

Modpack info

No response

The latest.log file

N/A

Issue description

Both Gaia Guardian tracks use the "record" channel (in the music settings listed as "Jukebox/Note Blocks") when played during the fight. This would be expected if you were using the music disc, but when not you're summoning the Gaia Gaurdian. There is precedent for using this channel for bossfight music: minecraft:music/game/end/boss uses the music channel.

This is apparently intentional, but I think it's unintuitive and would be an easy fix. Not being able to easily control its volume could be considered an accessibility issue.

Steps to reproduce

  1. Summon Gaia Guardian
  2. use /stopsound @p music and observe the music was not stopped
  3. use /stopsound @p record and observe the music was stopped

Other information

No response

commented

The thing is, the gaia fight music isn't an ambient music like the vanilla dragon fight music. It plays directly from the beacon, as if it was a jukebox, so having the jukebox volume controls (which do work, btw.) affect it does make sense to me.
Another reason against the music category is that the gaia fight music is in mono, i.e. it can't actually play as proper ambient music. (I believe it would even play over any ambient music that happens to be playing, instead of stopping that and preventing ambient music to start during the fight. Assigning different volume sliders are the only good way to control that.)

commented

As far as I'm aware, the Gaia music is downmixed to mono, so I imagine it could be implemented as ambient music.

Personally, I find it borderline headache-inducing for the music to be directional. It's fine for jukeboxes, but during the fight you'll be running all over the place, with the direction from which the music is playing constantly changing.

commented

In that case, a proper implementation would need to upgrade the music to stereo again (because non-directional mono music is weird, IMHO) and hook into the situational music logic to play this in a similar way as the dragon fight music. It would also mean a separate version of the music would be required for jukeboxes.