Mod Loader

Forge

Minecraft Version

1.20.1

Botania version

1.20.1-446

Modloader version

Forge 47.3.11

Modpack info

ATM9 0.3.5

The latest.log file

https://gist.github.com/AlisonHuang777/e275d3974d8979c6d71de622874cfeb7

Issue description

As the title described. The save file is corrupted and doomed to crash every time it loads afterwards.

Steps to reproduce

0. Create a new world (save).
1. Obtain a Gourmaryllis and a Purple Drink.
2. Plant the Gourmaryllis and feed it with the Purple Drink.
3. Game crashes.

Other information

No response

This may be an API misuse by GregTech. As the example in Wolf::isFood(ItemStack) suggests, items types that return true for isEdible() should also have some food properties, but the Purple Drink (and possibly others) return null from getFoodProperties().

We will probably implement a workaround, but it will likely mean the item is eaten without generating any mana.

You may want to report this to the GregTechCEu author(s) as well, if you didn't already.

Just FYI, this is because currently GregTech Modern implements Forge's net.minecraftforge.common.extensions.IForgeItem#getFoodProperties(ItemStack, LivingEntity) , but does not yet implement the (deprecated) net.minecraft.world.item.Item#getFoodProperties() method.

I suspect using the deprecated method breaks any mods that generate FoodProperties based off NBT data? E.g. for Culinary Construct, you will just get a hardcoded nutrition of 1 instead of the actual nutrition value:
https://github.com/illusivesoulworks/culinaryconstruct/blob/1.20.2/common/src/main/java/com/illusivesoulworks/culinaryconstruct/common/item/CulinaryItemBase.java

Yes, this is one of the downsides of Forge providing non-vanilla ways to do things, but marking the vanilla methods as deprecated to signal mod authors to not use them.

Botania is a multi-loader mod that originated on the Fabric platform (as in: after 1.12 it was completely ported to Fabric, and only later Forge support was added back in), so it's likely missing a lot of those Forge-specific modded features. At the moment I wonder if it makes sense to add support for the Forge-specific food property getter in the 1.20.1 version still, since the Gourmaryllis has other peculiar food-related issues, such as counting changes in NBT data as different food items. (see #4455)

I've raised GregTechCEu/GregTech-Modern/pull/2839 which should provide the correct FoodProperties for GregTech food.
I'm not aware of any Fabric mods which generate foods from NBT, but I guess if they exist they must be mixin based? Might be worth looking for one...

EDIT:
Sandwichable is a Fabric mod, but it just uses a dummy FoodComponent and put the actual food logic in finishUsing(...) - so I suspect there's no way to support Fabric food mods like this without special casing each of them :(