Mod Loader

Forge

Minecraft Version

1.20.1

Botania version

1.0.3-1.20.1

Modloader version

Forge 47.3.0

Modpack info

No response

The latest.log file

no error logs generated

Issue description

Thirst Was Taken is a mod that adds a thirst bar and a water purity system. It replaces the regular minecraft bucket of water with an "acceptable" water bucket, and adds a few other tiers, ranging from Dirty to Pure. When it's installed alongside Botania, you get completely locked out of Botania's progression, because you can no longer fill the petal apothecary with water to craft even the most basic of flowers. I've tried it with a bucket of every tier of water purity, and it just places a water source block above the apothecary.
Furthermore, picking up water that was placed in the world then resets it to "Dirty" tier, which can give you nausea and hunger if you drink it without purifying it again, so players will end up wasting a lot of time (and fuel if they're using a furnace) re-purifying their water after trying every type of water bucket with the same result. Thirst only modifies the items, not the water blocks itself, and they've done a pretty good job at modifying existing recipes to use the "acceptable" tier or higher instead of the vanilla water bucket, but it seems that the petal apothecary is searching for a very strict item interaction and not finding it.

Steps to reproduce

No response

Other information

I'm pretty sure this is related to how the apothecaries handle fluids with just the three simple blockstates water, lava, and empty (instead of having nbt data like an item frame or chest), but I've also duplicated the issue over to ghen-git/Thirst-Mod#180 just in case

I looked over the code a bit and can't really see what it actually does to water buckets that would stop them from working.
Botania checks the item the player uses on the Petal Apothecary, and if it's a fluid container that can provide at least a bucket worth of water or lava (as in the vanilla Fluids.WATER and Fluids.LAVA types, respectively), that amount is removed from the item and the apothecary is filled with that type of fluid. As far as I can tell, the Thirst mod only adds an NBT tag to existing water buckets, but does not change the fluid type they contain.

yeah, it's really weird. I have no idea why the nbt data would prevent that behavior, because all the buckets still normally place a regular vanilla water source block when used.

Actually, I might, come to think of it. Thirst has integrations with Create, so when it's drained into a fluid inventory like a tank, it's "acceptable water" (or dirty/slightly dirty/purified water, depending on the nbt), so it might not be considered as Fluids.WATER anymore, but something like Fluids.ACCEPTABLE_WATER instead, and then just still uses the vanilla methods for placing a water source from a bucket.

@TheRealWormbo sorry, I edited my comment, so you might not have seen the change. It might be possible to fix it if one of the two mods changed the Apothecary check to also allow for Thirst's Pure Water (turns out that it's a different fluid in when it's in tanks, so that's probably it)

I'm waiting for a comment from the mod's author, because I'm reasonably sure it is not an entirely different fluid, but a FluidStack of water with an NBT tag for the purity. The mod does not appear to define new fluids as such.

Nevermind, found the likely issue in Forge code. Similarly to how Minecraft vanilla ItemStack comparing has a mode that includes NBT data, FluidStacks can be compared that way as well, and that is what Forge uses by default when you ask a fluid bucket to drain 1000mB of a plain water FluidStack.

Until recently, we had a similar issue with the Flügel Tiara not detecting the Eye of the Flügel, but there we provided the code that did the stack comparison. I'll have to look into how to accept any kind of water from a fluid container. (It probably involves doing a simulated extraction first to test the fluid content.)