Botania (Fabric/Quilt)

Botania (Fabric/Quilt)

Mods
7M Downloads

Rod of the Seas is hardcoded to only fill vanilla buckets

ChiefArug opened this issue ยท 0 comments

commented

Mod Loader

Forge

Minecraft Version

1.20.1

Botania version

1.20.1-448

Modloader version

47.4.1

Modpack info

No response

The latest.log file

N/A

Issue description

The rod of the seas has an awesome ability to be able to fill buckets in the inventory, however this is hardcoded to only work for vanilla buckets:

Botania/Xplat/src/main/java/vazkii/botania/common/item/rod/SeasRodItem.java

Line 93 in 8bd069e

if (other.is(Items.BUCKET) && ManaItemHandler.instance().requestManaExactForTool(stack, player, COST, true)) {

Botania/Xplat/src/main/java/vazkii/botania/common/item/rod/SeasRodItem.java

Line 111 in 8bd069e

if (other.is(Items.BUCKET) && ManaItemHandler.instance().requestManaExactForTool(stack, player, COST, true)) {

It would be great to extend this to any item that exposes a fluid capability, so it supports filling other mods buckets and tanks (like tinkers tools with the tank modifier).

Also on the topic of inventory fluid management, I notice the extrapolated bucket doesn't support any of that right now...

Steps to reproduce

No response

Other information

No response