Botania (Fabric/Quilt)

Botania (Fabric/Quilt)

7M Downloads

Terra Shatterer ability toogling is too restrictive

TheRealWormbo opened this issue ยท 0 comments

commented

Mod Loader

Both Fabric and Forge (I confirm that I have tested both loaders and will specify both loader versions below)

Minecraft Version

1.20.1

Botania version

(any)

Modloader version

(any)

Modpack info

No response

The latest.log file

n/a

Issue description

As apparent from #4289 and other reports on the Discord, Reddit (when it was still a thing), and the forum, the Terra Shatterer's toogle has become too restricted with the last change. It requires not just sneaking, but also to not aim at any blocks. As far as I recall, this change was done because the ability to place torches (inherited from the Manasteel Pickaxe) would not work properly, especially when trying to place a torch on a usable block like redstone ore.

For usability's sake the conditions for toggling should be adjusted. There are three relevant conditions to take into account:

  • Whether the player is sneaking. If they are not, the Terra Shatterer will not toggle, but instead might try to place a torch from the player's inventory, like the Manasteel Pickaxe does.
  • Whether the player is holding an item in the off-hand. Using the off-hand item should always have priority, unless the player is sneaking and not looking at any blocks.
  • Whether the player is looking at any blocks. If they do, torches might be placed from the inventory, unless the player is sneaking. Off-hand items should always have priority while looking at a block.

Steps to reproduce

No response

Other information

Letting off-hand items have priority over manasteel torch/sapling placement was a change introduced in 1.18.1 that also affected the Terra Shatterer's activation. Back then, the toggle was simply on right-click, and sneaking was required to give the off-hand item priority.

During 1.19.2, the activation requirements changed to require sneaking and not looking at any blocks. That meant, while looking at any blocks or not sneaking, the Terra Shatterer's right-click functionality was exactly that of the Manasteel Pickaxe, which placed torches unless there is an item in the player's off-hand.