Botania (Fabric/Quilt)

Botania (Fabric/Quilt)

Mods
7M Downloads

Standard mana spreader bursts traveling through nether portals cause extremely high TPS spikes.

Flyte-less opened this issue ยท 2 comments

commented

Mod Loader

Forge

Minecraft Version

1.20.1

Botania version

1.20.1-450-forge

Modloader version

47.4.8

Modpack info

Most minimal setup possible (Botania, Curios, Patchouli, Spark for generating profile)

The latest.log file

No relevant info in log

Issue description

Image

Mana blaster and pulse mana spreader cause a single red spike as the nether loads in and then remains flat as long as mana continues being sent through the portal, but standard mana spreaders continue to cause lag spikes even after the initial firing.

https://spark.lucko.me/on7oiC6NE7

Steps to reproduce

  1. Generate a new world and travel for several chunks away from spawn until you are clear of the spawn chunks.
  2. Build a nether portal and enter it. In the nether place a mana spreader on one side and a mana pool on the opposite. Repeat the same in the nether.
Image Image

  1. Place and destroy a creative mana pool on top of either spreader and ensure that the mana beam is traveling though the portal and returning the same way.

  2. Alt+F3 and observe the spikes on the graph.

Other information

king626 on the VM discord suggested that it could be caused by the game loading chunks in the wrong dimension and this seems to be the case. Forceloading the chunks containing the portals but in their opposite respective dimension seems to mitigate this issue entirely.

commented

Fixed via e9cfbe3.

commented

What seems to be happening here is that the teleported burst attempts to look for a mana spreader at its source coordinates, but in the new dimension. This causes chunk loading and unloading at a location in the new dimension that is potentially not even generated yet.

Similar issues may exist with the Bore and Redirective lenses.