Let pure daisy recipes registered through the API provide the recipe time

Question

williewillus opened this issue 9 years ago · 9 comments

williewillus commented 9 years ago

from irc

yrsegal · Answer 1 · 2016-02-27T02:16:09.000Z

at least there should be a secondary constructor...

yrsegal · Answer 2 · 2016-02-27T02:15:57.000Z

wait, what? NO! You changed the API, breaking all mods which add pure daisy recipes.

williewillus · Answer 3 · 2016-02-27T02:26:18.000Z

look closer...the BotaniaAPI method is still there...

yrsegal · Answer 4 · 2016-02-27T04:00:39.000Z

I extend RecipePureDaisy... please just have a default constructor which is like the old one >.>

yrsegal · Answer 5 · 2016-02-27T04:03:32.000Z

it's not good form to remove without deprecation an old method from an API

williewillus · Answer 6 · 2016-02-27T07:01:39.000Z

the api can shift whatever at this time and I didn't think changing a constructor was so much work, but fine

yrsegal · Answer 7 · 2016-02-26T23:39:18.000Z

This requires an api change, so it should leave the old version intact and add a new version that the daisy checks for.

yrsegal · Answer 8 · 2016-02-27T14:48:55.000Z

the api should always add to it, never remove. That way, you won't break old addons.

williewillus · Answer 9 · 2016-02-27T20:13:30.000Z

It's not like you wouldn't have had to change it anyway (the constructor changed to use IBlockState in 1.8)

Anyways, readded.