Botania Unofficial

Botania Unofficial

795k Downloads

Mana spreaders should implement Block.rotateBlock

SoniEx2 opened this issue · 7 comments

commented

Mana spreaders should implement Block.rotateBlock, for native compatibility with Framez 2/Trajectory, wrenches and turntables (which have existed since BetterThanWolves (yes, back when it was still a Forge mod), but I don't know any current Forge mod which has them...)

(I'm banned from upstream :/)

Also (as of 1.8) this is a vanilla method so even more reason to implement it.

commented

I can't do it upstream and Trajectory is gonna add it whether you and @Vazkii like it or not. The only issue I see is that rotateBlock is abused by wrenches, but that's not your or @Vazkii's fault.

commented

"whether I like it or not" then why are you asking me in the first place if you have no intent of respecting my decision?
yeah no I can see why you're banned upstream with that attitude.
bye.

commented

how would it work if the spreader is not pointed on a strictly axis-aligned direction?

commented

It'll rotate exactly 90° and still not be pointed in a strictly axis-aligned direction, but still pointing on a different direction.

e.g.

^ turns into >

 ^
/  turns into -_>

This also means, if it's on a perfect diagonal, it'll rotate and point to all 4 diagonal directions.

commented

Also then, the question arises on what axis does it rotate?
Should it rotate on the y axis always or should it rotate on the axis of the spreader's head pointing?
This gets a bit too close to changing actual design, and if Vaz wanted to he would've implemented it already.

commented

It should rotate on the clicked axis, just like vanilla. Not y axis, not positioning axis.

Looks like I'll have to make some visual explanations of how it'd work...

commented

I know what you want, but I'm saying you're better off requesitng this from upstream, it's something possible in 1.7 already and it gets awfully close to changing design since it allows new mechanics and interactions to occur.