Botania Unofficial

Botania Unofficial

794k Downloads

Some special potatoes don't render properly.

luxor-g opened this issue · 13 comments

commented

The potaoes that have items (like Direwolf20, Etho, etc) don't render them in the right place.

Map with all potatoes: https://mega.nz/#F!Lo1xhKCS!H1cbRNIJGDq2kry_a21-8Q

commented

oh right, I fixed all the baubles but forgot the potatoes. >.>

commented

StackOverflow was recently shut down because of regex.

Even precompiled they can be very slow.

commented

@yrsegal wanna fix these as well? xD

commented

Sure, why not
On Fri, Jul 29, 2016 at 9:18 PM Vincent Lee [email protected]
wrote:

@yrsegal https://github.com/yrsegal wanna fix these as well? xD


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#409 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGSnjLp2QuHNZngV72YXm3lSM51Nc0bpks5qaqZkgaJpZM4JXlps
.

commented

thanks so much heh, the rendering things are aggravating to do

commented

do I have permission to fix longstanding minor bugs in the potato while i'm at it? (shia labeouf not stacking with colors, i remember at least one other existing)

commented

also to shift everything to regex so it's more expandable and safer

commented

yes to the first
no to the latter (why would we need it for one, and for two calling regex in a tight rendering loop is asking for lag and lots of it)

commented

the second: precompiled regex is pretty fast, and it's needed because some combinations of effects aren't possible without adding regex or complex testing that'd probably be slower

commented

why can't we just do two contains calls?

commented

"pretty fast" is still slower than it is right now :P

commented

i guess

commented

is this being worked on or can I stab at it tonight? (@yrsegal)