Floating flowers: FPS drop + [Possibly Unrelated | Optifine] [Strange bug] Crash with connected textures enabled
CrazyManLabs opened this issue ยท 1 comments
The first part of this issue is pretty much straight forward:
With only Forge and Botania installed I faced with FPS drop (in the past I never noticed this problem). FPS drops whenever I place/break Floating Flower, but a little bit later (maybe half a second or so) after that FPS returns to its' normal value. But sometimes game "lags" only on first flower placed or last flower broken (by "first/last flower" I mean that there is no other flowers in the world before placing/after breaking)..
The second part is..IDK..very strange and new to me.
It can be reproduced like this:
- Install MC + Forge + Botania + OptiFine (I leaved all my mods enabled, but it can be reproduced just in this combination)
- Enable "Connected Textures" feature in OptiFine
- Start game, load world (I tested only in flat world with "Redstone ready" template, so maybe only sandstone walls can cause this problem)
- 2 possible ways here:
4.1)
Place 2 Floating Flowers on the ground next to each other
-> Break block under/near them (on screenshots blocks, that need to be broken, highlighted)
-> Instant crash
Here are screenshots, where you can see, that blocks, that are further away from flowers, can be broken without any problem..
4.2)
Break some blocks in one line
-> Place Floating Flower on edge of this gap
-> Instant crash
I think this issue is optifine-related, but (as I told below) it never happened before.. And another reason for open issue here is part of log, that contains calls of botania methods on top of call-stack:
java.lang.NullPointerException: Tesselating block model at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:213) at com.google.common.collect.StandardTable.put(StandardTable.java:138) at com.google.common.collect.HashBasedTable.put(HashBasedTable.java:55) at vazkii.botania.client.model.FloatingFlowerModel.getModel(FloatingFlowerModel.java:135) at vazkii.botania.client.model.FloatingFlowerModel.func_188616_a(FloatingFlowerModel.java:104) at ConnectedTextures.getNeighbourIcon(ConnectedTextures.java:1325) at ConnectedTextures.isNeighbour(ConnectedTextures.java:1284) at ConnectedTextures.isNeighbour(ConnectedTextures.java:1264)
I think, that latest changes in Floating Flowers can cause this problem (possible "caching models" feature (as I can call it from code) or maybe new models causing it), but I can't tell, if I'm right.
CrashDump:
crash-2016-08-31_18.18.35-client.txt
Specs:
MC 1.10.2
Forge 12.18.1.2076
Botania r1.8-320
OptiFine 1.10.2_HD_U_C3