Botania

Botania

133M Downloads

Assembly Halo Incorrect Message With Full Inventory

natedogith1 opened this issue ยท 1 comments

commented

When I can't craft because my inventory is full, the assembly halo will tell me "Not enough Materials!" even though I have the materials.

commented

Error reproduced. When your inventory is full, as such:

2016-01-12_16 32 23

Then trying to craft an item results in "Not enough materials!":

2016-01-12_16 32 26

The easy way to fix this is to just change the message to be "Can't craft!". The more proper way to fix things is to have canCraft return an enum, one of VALID, NOT_ENOUGH_MATERIAL or INVENTORY_FULL, and then show the appropriate message based on this.

The second approach is rather straightforward but requires the creation of another localized string (called "botaniamisc.cantCraftFullInventory"), and the first localization should probably be renamed to "botaniamisc.cantCraftNoMaterials" or similar.