Botania

Botania

133M Downloads

AE2+Botania = Client crash with channels=false when viewing Quantum Ring recipe "Unnamed" cable item tooltip.

lossycrypt opened this issue · 6 comments

commented

This issue at AE2 issue tracker

Description:

When channels are disabled in AE2 config the "ME Dense Cable - Fluix" required for crafting a "ME Quantum Ring" is replaced by "Unnamed" with same ID and metadata. Trying to view the item tooltip if Botania is also installed crashes the client but has no effect on the server.

Steps to reproduce:
  • Have required mods.
  • Disable channels in AppliedEnergistics2.cfg: "networkfeatures {B:Channels=false}"
  • Open recipe for "ME Quantum Ring" in NEI.
  • Hover mouse over "Unnamed" cable.
  • Client crashes to Desktop.
Minimal mods to reproduce:

Forge 10.13.4.1448

│  appliedenergistics2-rv2-stable-10.jar
│  Botania r1.7-230.jar
│  CodeChickenCore-1.7.10-1.0.7.47-universal.jar
│  NotEnoughItems-1.7.10-1.0.5.118-universal.jar
└─1.7.10
        Baubles-1.7.10-1.0.1.10.jar
        CodeChickenLib-1.7.10-1.1.3.140-universal.jar
Crash log (Full Log):
java.lang.NullPointerException
    at appeng.items.parts.ItemMultiPart$PartTypeWithVariant.access$200(ItemMultiPart.java:355) ~[ItemMultiPart$PartTypeWithVariant.class:?]
    at appeng.items.parts.ItemMultiPart.func_77653_i(ItemMultiPart.java:206) ~[ItemMultiPart.class:?]
    at net.minecraft.item.ItemStack.func_82833_r(ItemStack.java:427) ~[add.class:?]
    at net.minecraft.item.ItemStack.func_82840_a(ItemStack.java:489) ~[add.class:?]
    at vazkii.botania.client.core.handler.TooltipAdditionDisplayHandler.render(TooltipAdditionDisplayHandler.java:62) ~[TooltipAdditionDisplayHandler.class:?]
    at vazkii.botania.client.core.handler.ClientTickHandler.renderTick(ClientTickHandler.java:54) ~[ClientTickHandler.class:?]
    at cpw.mods.fml.common.eventhandler.ASMEventHandler_98_ClientTickHandler_renderTick_RenderTickEvent.invoke(.dynamic) ~[?:?]
    at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54) ~[ASMEventHandler.class:?]
    at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:138) [EventBus.class:?]
    at cpw.mods.fml.common.FMLCommonHandler.onRenderTickEnd(FMLCommonHandler.java:340) [FMLCommonHandler.class:?]
    at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1003) [bao.class:?]
    at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:898) [bao.class:?]
    at net.minecraft.client.main.Main.main(SourceFile:148) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_80]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_80]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_80]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_80]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.11.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.11.jar:?]

How it looks without Botania:

Picture

commented

So any comment on this at all?
If you need the full log (like someone suggested to me afterwards >_>) i can make one.

commented

NEI/MC doesn't crash though unless Botania is also installed. Which was why i reported this in the first place. Maybe you could add some sanity checking to protect from other mods misbehavior?

commented

That should do it. They really should sort that out on their end though.

commented

This is an AE problem, as they do not name their items properly. The "Unnamed" string comes from NEI trying to fill in.

commented

i noticed steve's workbench has no itemname when not modified, you can probably check with that mod too

to AE i'd like to point out here, the disable channel funtion (resulting in unnamed items) was never a planned feature as it was never intentional to move away from the channel design .. so this always was only a trade off/compromise to the people who are not able to deal with channels
by the way RV3 is preeetty stable ... imho

commented

Supposedly it's going to be fixed in v3, but who knows when that goes retail.
Thanks anyway :).