Botania

Botania

Mods
133M Downloads

Terra Shatterer broken when full set of terrasteel armour is equipped.

RiskyKen opened this issue · 17 comments

commented

After updating from r1.7-237 to r1.8-241 the Terra Shatterer looks like it keeps getting updates or something causing it to reset it's mining progress.

If the player had more than one Terra Shatterer on their hotbar the 2nd one seems to work fine.

Not been able to reproduce this in single-player.

https://www.youtube.com/watch?v=atcqLWKWPhk

Forge: 10.13.4.1558-1.7.10
Botania: r1.8-241

EDIT
Additional Info
Other Botania picks work fine.
Botania was the only mod updated.

commented

modlist?

(we are the vigil of the issue tracker, in Vazkii's absence :3)

commented

Fml log?

commented

does anything happen in the log when you use a Shatterer and it fails?

commented

Have you also tried using the pick without any mana on you?

(Phones are annoying bastards when you need to read a pastebin, I hate my phone)

commented

Tried without the mana band still the same.

Don't see anything in the server or client logs when it happens.

commented

Is build 241 designed for the recommended version of forge, or the latest version of forge?

(I really need to get some sleep in order to understand code again so I'm just doing some basic troubleshooting and might look at it tomorrow... If vaskii-Senpai hasn't fixed it by then)

commented

I'm experiencing the same issue but it only occurs while wearing full set of terrasteel armour, no matter if single or multiplayer.
Just taking one piece of terrasteel armour off allows for usage of shatterer once again.

commented

@MikuPL Confirmed seems to be the same for me.

commented

Could you try no terrasteel, but a Greater Band of Mana?
On Tue, Dec 8, 2015 at 10:52 AM RiskyKen [email protected] wrote:

@MikuPL https://github.com/MikuPL Confirmed seems to be the same for me.

—
Reply to this email directly or view it on GitHub
#1626 (comment).

commented

I mean a band of Aura
On Tue, Dec 8, 2015 at 10:54 AM Wire Segal [email protected] wrote:

Could you try no terrasteel, but a Greater Band of Mana?
On Tue, Dec 8, 2015 at 10:52 AM RiskyKen [email protected] wrote:

@MikuPL https://github.com/MikuPL Confirmed seems to be the same for
me.

—
Reply to this email directly or view it on GitHub
#1626 (comment).

commented

I believe this is due to the filling effect of the Band of Aura/Terrasteel
armor, as they will fill Terra Shatterers. There needs to be a way to
blacklist mana items from such dispatches.
On Tue, Dec 8, 2015 at 10:54 AM Wire Segal [email protected] wrote:

I mean a band of Aura
On Tue, Dec 8, 2015 at 10:54 AM Wire Segal [email protected] wrote:

Could you try no terrasteel, but a Greater Band of Mana?
On Tue, Dec 8, 2015 at 10:52 AM RiskyKen [email protected]
wrote:

@MikuPL https://github.com/MikuPL Confirmed seems to be the same for
me.

—
Reply to this email directly or view it on GitHub
#1626 (comment).

commented

Seems to work fine with the Band of Aura or Greater Band of Aura equipped.

commented

The Bands fill slower than the armor. Try mining for a while, look for
small discrepancies.
On Tue, Dec 8, 2015 at 11:01 AM RiskyKen [email protected] wrote:

Seems to work fine with the Band of Aura or Greater Band of Aura equipped.

—
Reply to this email directly or view it on GitHub
#1626 (comment).

commented

Aha! That's how to fix the bug.
On Tue, Dec 8, 2015 at 11:05 AM RiskyKen [email protected] wrote:

Was just looking at this line should the armour not also be listed?
https://github.com/Vazkii/Botania/blob/9cf015ee972bb8568f65128fa7b84c12c4a7cfff/src/main/java/vazkii/botania/common/item/equipment/tool/terrasteel/ItemTerraPick.java#L271

—
Reply to this email directly or view it on GitHub
#1626 (comment).